Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docs for arm64 #167

Merged
merged 1 commit into from Jan 24, 2022
Merged

add docs for arm64 #167

merged 1 commit into from Jan 24, 2022

Conversation

szaimen
Copy link
Collaborator

@szaimen szaimen commented Jan 24, 2022

Close #28

Signed-off-by: szaimen szaimen@e.mail.de

Signed-off-by: szaimen <szaimen@e.mail.de>
@szaimen szaimen added 3. to review Waiting for reviews documentation Improvements or additions to documentation enhancement New feature or request labels Jan 24, 2022
@szaimen szaimen added this to the next milestone Jan 24, 2022
@szaimen szaimen merged commit 1b73df0 into main Jan 24, 2022
@delete-merged-branch delete-merged-branch bot deleted the enh/28/add-docs-for-arm64 branch January 24, 2022 14:00

- $name
- $digest
Go to https://github.com/nextcloud-releases/all-in-one/actions/workflows/repo-sync.yml and run the workflow that will first sync the repo and then build new container that automatically get published to `develop` and `develop-arm64`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiosity, is there a reason for the separate tags? It should be possible to build an image for multiple architectures using the same tag with https://docs.docker.com/buildx/working-with-buildx/

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there is one :)

See #42 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see, thanks for the quick reply :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no problem! Thanks for your reviews! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for ARM64
2 participants