Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not apply an empty allow list if none is set #4249

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Feb 19, 2024

Otherwise the empty array could block showing any apps from the store in apps management

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl juliushaertl added the bug Something isn't working label Feb 19, 2024
Copy link
Collaborator

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@szaimen szaimen added the 3. to review Waiting for reviews label Feb 19, 2024
@szaimen szaimen added this to the next milestone Feb 19, 2024
@szaimen szaimen merged commit 4a121ed into main Feb 19, 2024
3 checks passed
@szaimen szaimen deleted the bugfix/noid/appsallowlist branch February 19, 2024 15:16
@szaimen
Copy link
Collaborator

szaimen commented Feb 21, 2024

This is now released with v7.13.0 Beta. Testing and feedback is welcome! See https://github.com/nextcloud/all-in-one#how-to-switch-the-channel

@corincorvus
Copy link

corincorvus commented Feb 28, 2024

We are on v7.13.0 Beta now with update nextcloud on 28.0.2.
image
image

Empty Store:
image

@szaimen
Copy link
Collaborator

szaimen commented Feb 28, 2024

Hi @corincorvus I fear the change to this file only gets applied after Nextcloud gets updated. However you can modify the file yourself manually.

@corincorvus
Copy link

However you can modify the file yourself manually.

Hey,
its done, it work! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants