Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a jellyfin community-container #4267

Merged
merged 3 commits into from
Mar 4, 2024
Merged

Add a jellyfin community-container #4267

merged 3 commits into from
Mar 4, 2024

Conversation

AiroPi
Copy link
Collaborator

@AiroPi AiroPi commented Feb 22, 2024

This is a new pull request that follows the previous one from @burnclouds, which has not been merged due to no responses. I just reused his work, with small fixes (removing a comma in the JSON).

#3634

This also follows the idea from @burnclouds: #3500

The community-container works fine, but I was wondering if I can also add some "special rules" to the Caddy community-maintained container, so it adds a jellyfin subdomain to the server with HTTPS enabled? As it is the case for Bitwarden and Stalwart.

@AiroPi

This comment was marked as resolved.

Copy link
Collaborator

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Some remakrs...

community-containers/jellyfin/readme.md Outdated Show resolved Hide resolved
community-containers/jellyfin/readme.md Outdated Show resolved Hide resolved
AiroPi and others added 3 commits February 23, 2024 16:39
Signed-off-by: AiroPi <47398145+AiroPi@users.noreply.github.com>
Signed-off-by: Pıεяяε <47398145+AiroPi@users.noreply.github.com>
Oops, my copy/paste is spotted

Co-authored-by: Simon L. <szaimen@e.mail.de>
Signed-off-by: Pıεяяε <47398145+AiroPi@users.noreply.github.com>
- Added incompatibilities between Jellyfin and Plex.
- Included note about Caddy handling `media.$NC_DOMAIN`.
- Added information about setting up a reverse proxy.
- Included security notice for Jellyfin initial setup.

Signed-off-by: Pıεяяε <47398145+AiroPi@users.noreply.github.com>
@AiroPi
Copy link
Collaborator Author

AiroPi commented Feb 23, 2024

By the way, I was testing the Caddy config, but it seems that the Jellyfin container isn't attached to the nextcloud-aio network. Do you have any clue why? I started it using the master container web interface.

@szaimen
Copy link
Collaborator

szaimen commented Feb 23, 2024

By the way, I was testing the Caddy config, but it seems that the Jellyfin container isn't attached to the nextcloud-aio network. Do you have any clue why? I started it using the master container web interface.

Right. Forgot that. This is due to using the hodt network for the container... So this is something we need to figure out how to do properly...

@AiroPi
Copy link
Collaborator Author

AiroPi commented Feb 24, 2024

The address host.docker.internal can be used for the reverse-proxy, but I don't know how to check if jellyfin is installed and present.

@AiroPi
Copy link
Collaborator Author

AiroPi commented Feb 26, 2024

The address host.docker.internal can be used for the reverse-proxy, but I don't know how to check if jellyfin is installed and present.

Hm, for some reason host.docker.internal isn't accessible from the caddy container

Copy link
Collaborator

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! :)

@szaimen szaimen merged commit e7f98c0 into nextcloud:main Mar 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants