Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm - only add namespace if it is not default #4314

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

szaimen
Copy link
Collaborator

@szaimen szaimen commented Mar 4, 2024

Close #4298

Result:
image

@szaimen szaimen added 2. developing Work in progress enhancement New feature or request labels Mar 4, 2024
@szaimen szaimen added this to the next milestone Mar 4, 2024
Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen szaimen force-pushed the enh/4298/namespace-improvement branch from d6870a7 to f0bf35e Compare March 4, 2024 09:36
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 4, 2024
@szaimen szaimen marked this pull request as ready for review March 4, 2024 09:37
@szaimen szaimen requested a review from st3iny March 4, 2024 09:37
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works otherwise.

nextcloud-aio-helm-chart/update-helm.sh Outdated Show resolved Hide resolved
Signed-off-by: Simon L <szaimen@e.mail.de>

Co-authored-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: Simon L. <szaimen@e.mail.de>
@szaimen szaimen requested a review from st3iny March 4, 2024 10:16
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works.

@szaimen
Copy link
Collaborator Author

szaimen commented Mar 4, 2024

Great, thanks @st3iny! ☺️

@szaimen szaimen merged commit 64b1951 into main Mar 4, 2024
3 checks passed
@szaimen szaimen deleted the enh/4298/namespace-improvement branch March 4, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm Chart: Default namespace resource needs to installed optionally
2 participants