Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip any update procedure if nextcloud was just restored or backup failed or database export failed #64

Merged
merged 1 commit into from Dec 22, 2021
Merged

skip any update procedure if nextcloud was just restored or backup failed or database export failed #64

merged 1 commit into from Dec 22, 2021

Conversation

szaimen
Copy link
Collaborator

@szaimen szaimen commented Dec 7, 2021 •
edited

Close #23
Close #67
Close #69

This is best reviewed like this: https://github.com/nextcloud/all-in-one/pull/64/files?diff=unified&w=1If

The PR does basically two things:

  1. if the database export during the database container shutdown fails, it will block new backups from getting created and will also block automatically restoring the database from database export (if an import should be needed)
  2. if a backup fails or a backup was restored, it will not update the nextcloud the next time the nextcloud container starts up

Signed-off-by: szaimen szaimen@e.mail.de

@szaimen szaimen added 3. to review Waiting for reviews enhancement New feature or request labels Dec 7, 2021
@szaimen szaimen added this to the next milestone Dec 7, 2021
@szaimen szaimen force-pushed the enh/23/skip-nextcloud-update branch from 8c79fca to cfdc59c Compare December 7, 2021 17:52
@szaimen szaimen mentioned this pull request Dec 7, 2021
Closed
16 tasks
@szaimen szaimen force-pushed the enh/23/skip-nextcloud-update branch from cfdc59c to 95f5426 Compare December 7, 2021 18:50
@szaimen szaimen changed the title skip any update procedure if nextcloud was just restored skip any update procedure if nextcloud was just restored or backup failed Dec 7, 2021
@szaimen szaimen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Dec 8, 2021
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 10, 2021
@szaimen
skip any update procedure if nextcloud was just restored and more
2ab0480 
Signed-off-by: szaimen <szaimen@e.mail.de>
@szaimen szaimen changed the title skip any update procedure if nextcloud was just restored or backup failed skip any update procedure if nextcloud was just restored or backup failed or database export failed Dec 10, 2021
@szaimen szaimen merged commit 948f322 into main Dec 22, 2021
@delete-merged-branch delete-merged-branch bot deleted the enh/23/skip-nextcloud-update branch December 22, 2021 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azul azul Awaiting requested review from azul

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

@LukasReschke LukasReschke Awaiting requested review from LukasReschke

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Milestone
v0.1.0
1 participant
@szaimen