Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customize php-fpm config #91

Merged
merged 1 commit into from Dec 29, 2021
Merged

customize php-fpm config #91

merged 1 commit into from Dec 29, 2021

Conversation

szaimen
Copy link
Collaborator

@szaimen szaimen commented Dec 29, 2021

Close #79

Signed-off-by: szaimen szaimen@e.mail.de

Signed-off-by: szaimen <szaimen@e.mail.de>
@szaimen szaimen added 3. to review Waiting for reviews enhancement New feature or request labels Dec 29, 2021
@szaimen szaimen added this to the next milestone Dec 29, 2021
@szaimen szaimen requested a review from artonge December 29, 2021 13:58
@szaimen szaimen added the performance Performances issues and optimisations label Dec 29, 2021
@artonge
Copy link

artonge commented Dec 29, 2021

I would have COPY the config files into their final destinations instead of inlining some sed commands.
The values should be fine though.

Copy link
Member

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, though having fixed numbers is kind of hard without knowing the underlying available system ressources.

@szaimen
Copy link
Collaborator Author

szaimen commented Dec 29, 2021

I would have COPY the config files into their final destinations instead of inlining some sed commands.
The values should be fine though.

Thanks for the feedback! Yes, usually I would copy the whole conf but since I only want to substitute those values, I opted for doing it like this. We can still change this without any problem later on.

Seems good, though having fixed numbers is kind of hard without knowing the underlying available system ressources.

Thats right but lets do it like this for now and we can later on change it or maybe also improve it to set the value during runtime.

@szaimen szaimen merged commit 06537c7 into main Dec 29, 2021
@delete-merged-branch delete-merged-branch bot deleted the enh/79/customize-php-fpm-config branch December 29, 2021 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request performance Performances issues and optimisations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust the php config to sane defaults
3 participants