New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable login if Nextcloud is running #94
Conversation
3c3209c
to
899ec7a
Compare
899ec7a
to
127df00
Compare
Signed-off-by: szaimen <szaimen@e.mail.de>
127df00
to
0010a6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this also be blocked then in the actual login controller? Otherwise it would just be the form that is hidden.
Would still be good to have a way to manually enable the login as mentioned in #3 to have a way to get back to it if something
went wrong on the Nextcloud side.
Thanks for the review, julius :)
Not sure how important that is since it should fail in that case due to the csrf check?
Already implemented. See https://github.com/nextcloud/all-in-one/pull/94/files#diff-e91b468a29aee3ff92547f02d1032086caca43138d1f9c5f693dea700f3e6058R17-R18 :) |
Signed-off-by: szaimen <szaimen@e.mail.de>
This is best reviewed like this: https://github.com/nextcloud/all-in-one/pull/94/files?diff=unified&w=1
Close #3
Signed-off-by: szaimen szaimen@e.mail.de