-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change sharees format #325
Conversation
Codecov Report
@@ Coverage Diff @@
## master #325 +/- ##
==========================================
+ Coverage 21.58% 25.38% +3.79%
==========================================
Files 117 118 +1
Lines 5166 5220 +54
Branches 701 711 +10
==========================================
+ Hits 1115 1325 +210
+ Misses 3921 3735 -186
- Partials 130 160 +30
|
This currently cannot work as server PR needs first to be merged. |
dcc2611
to
5f30580
Compare
20ee387
to
cb58df5
Compare
} | ||
} else { | ||
Log_OC.e("WebdavEntry", "General fuckup, no status for webdav response"); | ||
} | ||
} | ||
|
||
private @Nullable | ||
ShareeUser createShareeUser(Element element) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be a single line
private @Nullable ShareeUser createShareeUser(Element element) {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a minor formatting comment
f14b00e
to
bd47e7e
Compare
bd47e7e
to
1e7e1f6
Compare
IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/1180 |
1e7e1f6
to
f592545
Compare
Lint
SpotBugs (new)
SpotBugs (master)
SpotBugs increased! |
IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/1182 |
f592545
to
14f2b85
Compare
IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/1183 |
69b1246
to
828e6a9
Compare
Lint
SpotBugs (new)
SpotBugs (master)
SpotBugs increased! |
Lint
SpotBugs (new)
SpotBugs (master)
SpotBugs increased! |
828e6a9
to
e2b8892
Compare
Lint
SpotBugs (new)
SpotBugs (master)
SpotBugs increased! |
e2b8892
to
c425a43
Compare
Lint
SpotBugs (new)
SpotBugs (master)
Lint increased! |
- add ShareeUser, with userId and displayName - add tests - add group support - no need of own hashCode create user/group in drone Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
c425a43
to
a219fbe
Compare
Lint
SpotBugs (new)
SpotBugs (master)
|
Needs: nextcloud/server#14429
Only merge if this is in NC17, otherwise change it.
Needs new server image, as it needs
user1, displayName: "User One"
user2, displayName: "User Two"
users group: with user1, user2
Signed-off-by: tobiasKaminsky tobias@kaminsky.me