Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process element color theming values #464

Merged
merged 1 commit into from
Jul 3, 2020
Merged

Conversation

AndyScherzinger
Copy link
Member

adding color values for element see also nextcloud/server#21586 ff.
Available with Nc 19.0.1 server

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@nextcloud-android-bot
Copy link
Collaborator

Lint

TypemasterPR
Warnings11
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings14
Correctness Warnings38
Internationalization Warnings6
Malicious code vulnerability Warnings7
Multithreaded correctness Warnings3
Performance Warnings17
Security Warnings1
Dodgy code Warnings41
Total127

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings14
Correctness Warnings38
Internationalization Warnings6
Malicious code vulnerability Warnings7
Multithreaded correctness Warnings3
Performance Warnings17
Security Warnings1
Dodgy code Warnings41
Total127

@codecov
Copy link

codecov bot commented Jul 2, 2020

Codecov Report

Merging #464 into master will decrease coverage by 0.00%.
The diff coverage is 38.46%.

@@            Coverage Diff             @@
##           master     #464      +/-   ##
==========================================
- Coverage   39.47%   39.47%   -0.01%     
==========================================
  Files         136      136              
  Lines        5897     5910      +13     
  Branches      771      777       +6     
==========================================
+ Hits         2328     2333       +5     
- Misses       3223     3225       +2     
- Partials      346      352       +6     
Impacted Files Coverage Δ
...sources/status/GetCapabilitiesRemoteOperation.java 46.77% <33.33%> (-0.51%) ⬇️
...oud/android/lib/resources/status/OCCapability.java 53.39% <50.00%> (-0.14%) ⬇️

@tobiasKaminsky tobiasKaminsky merged commit 9d8a2e8 into master Jul 3, 2020
@delete-merged-branch delete-merged-branch bot deleted the elementColors branch July 3, 2020 05:35
@AndyScherzinger AndyScherzinger added this to the NC Android lib 2.3.0 milestone Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants