Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delayed deletion of photos #1899

Closed
scoopex opened this issue Dec 31, 2017 · 10 comments
Closed

Delayed deletion of photos #1899

scoopex opened this issue Dec 31, 2017 · 10 comments

Comments

@scoopex
Copy link

scoopex commented Dec 31, 2017

I really like the automatic upload and automatic deletion functionality for photos and videos, because this saves space on my android devices and make new photos and videos quickly available on my desktop system/nextcloud server.

There is only one thing which is little bit annoying:
Very often the upload and deletion is already performed when i want to review the media files on my phone (with familiy members, friends, ....) and it is a bit clumsy to reach these medias...

Therefore it will be great to have the possibility to delay the deletion of the media files if the are already uploaded after a certain amount of days.
A fixed amount of days (i.e 14 days) would be great for a initial implementation to reduce the amount of modifications of the ui.

@tobiasKaminsky tobiasKaminsky changed the title Feature request: Delayed deletion of photos Delayed deletion of photos Jan 2, 2018
@tobiasKaminsky
Copy link
Member

I recall that there was a discussion about this some time ago.
If I remember correctly the idea was not to add this as, but the user can simply click on the folder and delete it locally.
But having one option "delete after 14 days" in the option menu of an upload folder would also be fine for me.
Let's see what others say?

@scoopex
Copy link
Author

scoopex commented Jan 3, 2018

I think this is a very common usecase: Users will welcome to have the photos for a certain of time on their smartphone.

Probably a variant of this feature request would be smarter:

  • the photos can be moved to the Nextcloud folder (common photo apps should find them anyway?) in a regular way
  • Add a cache limit to folders, which removes locally cached files by a age limit or probably size limit (i.e. 200MB cache for this folder, keep most recent files)

@mario
Copy link
Contributor

mario commented Jan 3, 2018

The discussion ended in a way that (at least) @AndyScherzinger and me agree that ALL Auto-upload behaviours need to be removed.

@tobiasKaminsky
Copy link
Member

Well that would be really pity if we drop this as this is very often used feature as far as I can read...
And of course I personally really like it ;-)

@scoopex
Copy link
Author

scoopex commented Jan 4, 2018

I also agree, managing the free space of my phone by automatic upload and deletion might be a key feature for many users....

@mario
Copy link
Contributor

mario commented Jan 4, 2018

Well then the behaviours need to be fixed properly to work in 99% of cases (which I'm not sure is possible), and they most definitely don't at this moment. I am not a fan of filling the app with features in general.

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Jan 14, 2018

My reasons for voting to remove the behaviors are two:

  • other apps like Google photos for example also don’t manipulate the files of other apps, non-app locations
  • we would have to test file manipulations prior to offering them on a per device folder level

@tobiasKaminsky
Copy link
Member

other apps like Google photos for example also don’t manipulate the files of other apps, non-app locations

This does not mean that we cannot be "better" ;-)

we would have to test file manipulations prior to offering them on a per device folder level

Yes, this is my idea: to test on setup of auto upload folder if it is possible and only then show the option. Otherwise show a info that the storage is "readonly".

@doits
Copy link

doits commented Oct 28, 2019

This would be a killer feature IMO. I'd use this for the regular camera/DCIM folder: Remove pictures older than say 6 months, remove videos older than 1 month (for example).

Currently I have to do this manually, but there is one flaw: I cannot be sure the file has been uploaded! I had the case that some files did not manage to be uploaded (maybe due to bugs, maybe by bad luck etc.), so I am hesitant to delete them without checking first that there is a copy on the server. Which means I only do this manually for videos for now, because it saves the most space per file - and I found 3-4 out of maybe 40 which weren't uploaded in my last few runs, so this fear is not theoretical for me. (I have the idea to write a script that does this check automatically by looking for the file through maybe webdav and only deleting it when found or uploading it when not - but this feels like replicating auto upload.)

Would be nice to have such a feature in the app directly: To delete old files when uploaded, but with a delay.

(When I finally come to write that mentioned script I'll post it, so maybe other users (probably with a rooted phone / adb connection) will be able to use it.)

@joshtrichards
Copy link
Member

Let's consolidate this into #2323

@joshtrichards joshtrichards closed this as not planned Won't fix, can't repro, duplicate, stale Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants