Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage shortcuts #6363

Open
stefan-niedermann opened this issue Jun 25, 2020 · 3 comments
Open

Manage shortcuts #6363

stefan-niedermann opened this issue Jun 25, 2020 · 3 comments

Comments

@stefan-niedermann
Copy link
Member

stefan-niedermann commented Jun 25, 2020

Origin: #5522 by @wiwie

We should provide Android shortcuts (available since Android 7) for different purposes. Best example would be custom "jump targets", so one can create customized launchers.

Main issue is that this feature won't be used by everyone and therefore will clutter the menus everywhere, so we have to find a way to provide this feature without disturbing other people.

Proposal:

1. Create one static shortcut "Add shortcut" *

This will appear when long pressing the main app launcher:

grafik

2. Starting this shortcut will launch a "Manage shortcuts" picker

This should launch some kind of "target" picker where the user can navigate to the folder / file which should be the target of the shortcut.

Advantages:

  • People who are looking for shortcuts will find this
  • Already existing menus aren't cluttered
  • This implementation theoretically allows to develop this feature in a completely optional feature module

* Why only "Add shortcut" and not "Manage shortcut"? Because android only allows to add new shortcuts but not delete existing ones. This is completely up to the user. Attention: The implementation has to catch the case where a shortcut has been launched for a file / folder which does no longer exist.

Possible follow-up issues (out of scope for this issue):

  • automatically add dynamic shortcuts for the last used files / folders
  • static shortcuts for targets like "Favorites", "Photos", "Shared", "Trashbin"...?
@tobiasKaminsky
Copy link
Member

Let us also discuss which shortcuts we want to have, so that development does not go in wrong direction.
My suggestion would be to start with:

From sidebar:

  • favorites
  • photos

General:

  • link to file
  • link to folder
    -> opens up chooser

@stefan-niedermann
Copy link
Member Author

I like your proposal. It sounds like a good compromise: Add "⭐️ Favorites" and "🖼 Photos" as two other static shortcuts and allow to pin shortcuts to files / folders from the picker to the homescreen ("➕ Add shortcut"). No need to display dynamic shortcuts in the first step directly at the launcher.

Technical side note:

While the API allows to display up to 5 shortcuts when long pressing the main launcher, most of the default launchers will only display 4 shortcuts when long pressing the main launcher.
If we have the "➕ Add shortcut" shortcuts feature there (as suggested in this issue), we will have that as 1 permanent shortcut, so 3 free shortcut places which we could fill.

@aslmx
Copy link

aslmx commented Aug 10, 2021

Any news?
I read through the issues and later ended up in this PR and it looked to me like it is almost finished.
it would be a very useful feature.
Thanks to anyone who contributed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants