Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to create encrypted folder directly via bottom sheet dialog #10782

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Oct 6, 2022

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

  • Tests written, or not not needed

@tobiasKaminsky
Copy link
Member Author

/rebase

@AlvaroBrey
Copy link
Member

/rebase

@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Merging #10782 (85e1429) into master (edec670) will decrease coverage by 0.76%.
The diff coverage is 10.20%.

❗ Current head 85e1429 differs from pull request most recent head c584fdc. Consider uploading reports for the commit c584fdc to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #10782      +/-   ##
============================================
- Coverage     31.55%   30.79%   -0.76%     
+ Complexity     3424     3275     -149     
============================================
  Files           576      564      -12     
  Lines         42134    41652     -482     
  Branches       5685     5644      -41     
============================================
- Hits          13294    12827     -467     
- Misses        26868    26894      +26     
+ Partials       1972     1931      -41     
Impacted Files Coverage Δ
...m/owncloud/android/services/OperationsService.java 37.22% <0.00%> (+0.26%) ⬆️
...owncloud/android/ui/adapter/OCFileListAdapter.java 39.57% <0.00%> (-6.06%) ⬇️
.../android/ui/dialog/CreateFolderDialogFragment.java 0.00% <0.00%> (ø)
...droid/ui/fragment/OCFileListBottomSheetDialog.java 0.00% <0.00%> (ø)
...ncloud/android/ui/fragment/OCFileListFragment.java 35.29% <0.00%> (-4.53%) ⬇️
...cloud/android/ui/helpers/FileOperationsHelper.java 8.09% <0.00%> (+0.07%) ⬆️
...loud/android/operations/CreateFolderOperation.java 72.18% <45.45%> (-2.29%) ⬇️
...com/nextcloud/client/database/entity/FileEntity.kt 0.00% <0.00%> (-96.67%) ⬇️
...owncloud/android/authentication/PassCodeManager.kt 33.89% <0.00%> (-38.17%) ⬇️
...com/owncloud/android/utils/theme/ViewThemeUtils.kt 58.33% <0.00%> (-33.98%) ⬇️
... and 88 more

Copy link
Member

@AlvaroBrey AlvaroBrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotbugs + below comment

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@github-actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10782.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link

Codacy

Lint

TypemasterPR
Warnings7676
Errors00

SpotBugs

CategoryBaseNew
Bad practice2727
Correctness4444
Dodgy code331334
Internationalization99
Multithreaded correctness99
Performance5858
Security1818
Total496499

SpotBugs increased!

@nextcloud-android-bot
Copy link
Collaborator

@nextcloud-android-bot
Copy link
Collaborator

surinder-tsys added a commit to nextmcloud/android that referenced this pull request Jun 27, 2023
surinder-tsys added a commit to nextmcloud/android that referenced this pull request Jun 27, 2023
surinder-tsys added a commit to nextmcloud/android that referenced this pull request Aug 28, 2023
surinder-tsys added a commit to nextmcloud/android that referenced this pull request Oct 20, 2023
surinder-tsys added a commit to nextmcloud/android that referenced this pull request Oct 31, 2023
surinder-tsys added a commit to nextmcloud/android that referenced this pull request Nov 2, 2023
surinder-tsys added a commit to nextmcloud/android that referenced this pull request Dec 6, 2023
surinder-tsys added a commit to nextmcloud/android that referenced this pull request Dec 6, 2023
surinder-tsys added a commit to nextmcloud/android that referenced this pull request Dec 27, 2023
surinder-tsys added a commit to nextmcloud/android that referenced this pull request Jan 10, 2024
surinder-tsys added a commit to nextmcloud/android that referenced this pull request Jan 17, 2024
surinder-tsys added a commit to nextmcloud/android that referenced this pull request Jan 17, 2024
surinder-tsys added a commit to nextmcloud/android that referenced this pull request Feb 8, 2024
surinder-tsys added a commit to nextmcloud/android that referenced this pull request Feb 14, 2024
github-actions bot pushed a commit to nextmcloud/android that referenced this pull request May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants