Resolved - IndexOutOfBoundsException in Favorite view

[ayushbhanu]

• Tests written, or not not needed

[nextcloud-android-bot]

master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/6932-IT-master-19-46

[nextcloud-android-bot]

stable-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/6932-IT-stable-19-46

[AlvaroBrey]

I don't think it's a good idea to just swallow exceptions instead of finding their cause and adressing it. In #10725 you mention this is caused by "a bug in recycler view which is still not resolved", do you have any references for that?

You also say that RecyclerView Data modified in different thread, do you have any idea which part of the Nextcloud code is changing RV data in background? That should be easy to fix if it's located.

Additionally, clearing the RV pool is just not a good idea. The RV will handle that more efficiently.

Can you provide a way to reproduce the crash (without this patch)?

[ayushbhanu]

I don't think it's a good idea to just swallow exceptions instead of finding their cause and adressing it. In #10725 you mention this is caused by "a bug in recycler view which is still not resolved", do you have any references for that?

You also say that RecyclerView Data modified in different thread, do you have any idea which part of the Nextcloud code is changing RV data in background? That should be easy to fix if it's located.

Additionally, clearing the RV pool is just not a good idea. The RV will handle that more efficiently.

Can you provide a way to reproduce the crash (without this patch)?

For the first questions you can also have a look on below stackoverflow link , its is a popular issue.
link - https://stackoverflow.com/questions/31759171/recyclerview-and-java-lang-indexoutofboundsexception-inconsistency-detected-in?page=1&tab=scoredesc#tab-top

Regarding code for thread i am not sure about it but what I understood is that this crash is caused by RV internal threads and above link helps in catching that.

This crash is occuring sometimes when a user scrolls the screen , there is not an exact scenerio to reproduce it.