Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-3.23] show only one setup dialog, prevents strange situation on double tapping #11129

Merged
merged 2 commits into from Dec 12, 2022

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #11106

tobiasKaminsky and others added 2 commits December 2, 2022 10:32
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Co-authored-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: Tobias Kaminsky <tobias@nextcloud.com>
@github-actions
Copy link

github-actions bot commented Dec 2, 2022

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11129.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link

github-actions bot commented Dec 2, 2022

Lint

Typestable-3.23PR
Warnings8282
Errors00

SpotBugs

CategoryBaseNew
Bad practice2727
Correctness4545
Dodgy code341340
Internationalization99
Multithreaded correctness99
Performance5858
Security1818
Total507506

@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Merging #11129 (c6f35e7) into stable-3.23 (ff03e18) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files
@@                Coverage Diff                @@
##             stable-3.23   #11129      +/-   ##
=================================================
- Coverage          30.90%   30.89%   -0.02%     
+ Complexity          3286     3275      -11     
=================================================
  Files                564      564              
  Lines              41544    41547       +3     
  Branches            5651     5653       +2     
=================================================
- Hits               12841    12836       -5     
- Misses             26769    26782      +13     
+ Partials            1934     1929       -5     
Impacted Files Coverage Δ
...ncloud/android/ui/fragment/OCFileListFragment.java 35.61% <0.00%> (-0.13%) ⬇️
.../com/owncloud/android/ui/dialog/LoadingDialog.java 0.00% <0.00%> (-95.24%) ⬇️
.../owncloud/android/datamodel/MediaFoldersModel.java 40.00% <0.00%> (-20.00%) ⬇️
...va/com/owncloud/android/utils/FilesSyncHelper.java 14.60% <0.00%> (-6.75%) ⬇️
...nextcloud/client/jobs/MediaFoldersDetectionWork.kt 22.87% <0.00%> (-5.23%) ⬇️
...com/owncloud/android/ui/activity/FileActivity.java 22.64% <0.00%> (-4.05%) ⬇️
...a/com/owncloud/android/utils/FileStorageUtils.java 54.77% <0.00%> (-2.95%) ⬇️
...cloud/android/datamodel/UploadsStorageManager.java 71.05% <0.00%> (-2.31%) ⬇️
...cloud/android/ui/helpers/FileOperationsHelper.java 5.30% <0.00%> (-2.28%) ⬇️
...loud/android/operations/CreateFolderOperation.java 74.46% <0.00%> (-1.42%) ⬇️
... and 11 more

@AlvaroBrey AlvaroBrey merged commit df37a88 into stable-3.23 Dec 12, 2022
@delete-merged-branch delete-merged-branch bot deleted the backport/11106/stable-3.23 branch December 12, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants