potential fix for #6248

[tobiasKaminsky]

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

• Tests written, or not not needed

[codecov]

Codecov Report

Merging #11161 (ecbea61) into master (0b3707c) will decrease coverage by 0.86%.
The diff coverage is n/a.

❗ Current head ecbea61 differs from pull request most recent head b8791e2. Consider uploading reports for the commit b8791e2 to get more accurate results

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #11161      +/-   ##
============================================
- Coverage     31.58%   30.72%   -0.86%     
+ Complexity     3400     3264     -136     
============================================
  Files           566      564       -2     
  Lines         41601    41611      +10     
  Branches       5628     5640      +12     
============================================
- Hits          13138    12784     -354     
- Misses        26508    26895     +387     
+ Partials       1955     1932      -23     

Impacted Files	Coverage Δ
...com/nextcloud/client/database/entity/FileEntity.kt	0.00% <0.00%> (-96.60%)	⬇️
.../com/owncloud/android/ui/dialog/LoadingDialog.java	0.00% <0.00%> (-95.24%)	⬇️
...owncloud/android/authentication/PassCodeManager.kt	33.89% <0.00%> (-38.17%)	⬇️
...main/java/com/owncloud/android/utils/FileUtil.java	60.00% <0.00%> (-26.67%)	⬇️
...owncloud/android/ui/activity/PassCodeActivity.java	0.51% <0.00%> (-25.65%)	⬇️
.../owncloud/android/datamodel/MediaFoldersModel.java	40.00% <0.00%> (-20.00%)	⬇️
...owncloud/android/ui/adapter/OCFileListAdapter.java	39.76% <0.00%> (-6.20%)	⬇️
...nextcloud/client/jobs/MediaFoldersDetectionWork.kt	22.87% <0.00%> (-5.23%)	⬇️
...ncloud/android/ui/fragment/OCFileListFragment.java	35.61% <0.00%> (-4.48%)	⬇️
...d/android/operations/SynchronizeFileOperation.java	20.21% <0.00%> (-4.26%)	⬇️
... and 34 more

[AlvaroBrey]

AFAIK this permission has to be requested at runtime, it's not automatically granted.

[tobiasKaminsky]

AFAIK this permission has to be requested at runtime, it's not automatically granted.

Seems to work, according to users in #6248

But here it is said that it "requires explicit user consent in order to gain access to this information":
https://developer.android.com/training/data-storage/shared/media#media-location-permission

[github-actions]

blue-Light-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/11161-Screenshot-blue-Light-12-49

[nextcloud-android-bot]

master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/7435-IT-master-15-03

[joshtrichards]

I'm wondering if the need for this is only arising as a side effect of permitting users to choose to permit All Files Access (MANAGE_EXTERNAL_STORAGE / ACTION_MANAGE_ALL_FILES_ACCESS_PERMISSION)... or not.

What if we just don't let them choose and make it "You must say yes" to this intent action when you install if you want Nextcloud to function properly.

Storage permissions are a PITA to sort out with all the different Android versions. 😢 Worse if we support different combinations of permissions by default.

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	74	74
Errors	0	0

SpotBugs

Category	Base	New
Bad practice	26	26
Correctness	70	70
Dodgy code	363	363
Experimental	2	2
Internationalization	9	9
Malicious code vulnerability	2	2
Multithreaded correctness	9	9
Performance	58	58
Security	18	18
Total	557	557

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11161.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[github-actions]

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.