Moved splash screen setup strings to avoid merge issue during build process #11731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyScherzinger
approved these changes
Jun 12, 2023
|
Sounds good, merged @surinder-tsys 👍 |
|
Wow...That's fast. Thank you. |
|
Well, you just moved to items within the file, so that doesn't change any behavior and I just saw it and took a look and merged 😊 |
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11731.apk |
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the merging build process the app_name and other setup strings gets duplicated as the placement of splashScreenBold strings are right after the app_name.
setup.xml output
So to avoid this issue we have to place the text somewhere bottom.