Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable-3.27] Fix collabora files not loading #12350

Merged
merged 1 commit into from Jan 16, 2024
Merged

[stable-3.27] Fix collabora files not loading #12350

merged 1 commit into from Jan 16, 2024

Conversation

backportbot-nextcloud[bot]
Copy link

Backport of #12349

@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud App 3.27.0 milestone Jan 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2024

Lint

Typestable-3.27PR
Warnings7070
Errors33

SpotBugs

CategoryBaseNew
Bad practice2626
Correctness6868
Dodgy code360360
Experimental22
Internationalization99
Malicious code vulnerability22
Multithreaded correctness99
Performance5555
Security1818
Total549549

joshtrichards
joshtrichards approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@joshtrichards joshtrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested/backport works as expected.

@joshtrichards
Copy link
Member

I believe the milestone on this should be v3.27.1 since v3.27.0 is already out :)

@joshtrichards joshtrichards mentioned this pull request Jan 13, 2024
Closed
4 tasks
@tobiasKaminsky tobiasKaminsky modified the milestones: Nextcloud App 3.27.0, Nextcloud App 3.27.1 Jan 15, 2024
@tobiasKaminsky
Copy link
Member

/rebase

@JonasMayerDev @tobiasKaminsky
Allow null for loadUrl
6464705 
Signed-off-by: Jonas Mayer <jonas.a.mayer@gmx.net>
@github-actions GitHub Actions
Copy link

Lint

Typestable-3.27PR
Warnings7070
Errors33

SpotBugs

CategoryBaseNew
Bad practice2626
Correctness6868
Dodgy code360360
Experimental22
Internationalization99
Malicious code vulnerability22
Multithreaded correctness99
Performance5555
Security1818
Total549549

@github-actions GitHub Actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12350.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions GitHub Actions
Copy link

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@tobiasKaminsky tobiasKaminsky merged commit 795bccd into stable-3.27 Jan 16, 2024
16 of 17 checks passed
@delete-merged-branch delete-merged-branch bot deleted the backport/12349/stable-3.27 branch January 16, 2024 06:07
This was referenced Jan 25, 2024
Closed
Closed
Closed
@joshtrichards joshtrichards mentioned this pull request Mar 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshtrichards joshtrichards joshtrichards approved these changes

@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes

@JonasMayerDev JonasMayerDev Awaiting requested review from JonasMayerDev

Assignees
No one assigned
Labels
3. to review bug feature: editor regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joshtrichards @tobiasKaminsky @JonasMayerDev