Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Crash Show Fragment During FileActivity Lifecycle Change #12793

Closed
wants to merge 2 commits into from
+14 −11
Closed

Fix Crash Show Fragment During FileActivity Lifecycle Change #12793

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02c7ebe
Fix by Alper
JonasMayerDev Apr 2, 2024
fe47473
Update app/src/main/java/com/owncloud/android/ui/activity/FileActivit…
alperozturk96 May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
25 changes: 14 additions & 11 deletions app/src/main/java/com/owncloud/android/ui/activity/FileActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,17 +520,20 @@ protected void updateFileFromDB(){
* Show loading dialog
*/
public void showLoadingDialog(String message) {
// grant that only one waiting dialog is shown
dismissLoadingDialog();
// Construct dialog
Fragment frag = getSupportFragmentManager().findFragmentByTag(DIALOG_WAIT_TAG);
if (frag == null) {
Log_OC.d(TAG, "show loading dialog");
LoadingDialog loading = LoadingDialog.newInstance(message);
FragmentManager fm = getSupportFragmentManager();
FragmentTransaction ft = fm.beginTransaction();
loading.show(ft, DIALOG_WAIT_TAG);
fm.executePendingTransactions();

if (mResumed) {
// grant that only one waiting dialog is shown
dismissLoadingDialog();
// Construct dialog
Fragment frag = getSupportFragmentManager().findFragmentByTag(DIALOG_WAIT_TAG);
if (frag == null) {
Log_OC.d(TAG, "show loading dialog");
LoadingDialog loading = LoadingDialog.newInstance(message);
FragmentManager fm = getSupportFragmentManager();
FragmentTransaction ft = fm.beginTransaction();
ft.add(loading, DIALOG_WAIT_TAG);
ft.commitAllowingStateLoss();
}
}
}

Expand Down