Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automatic Per App Languages #12875

Merged
merged 2 commits into from Apr 30, 2024

Conversation

Arthur-GYT
Copy link
Contributor

@Arthur-GYT
Copy link
Contributor Author

@AndyScherzinger
Copy link
Member

@Arthur-GYT yes, there is a single screenshot test that needs fixing. I think @alperozturk96 is looking into that one.

Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@alperozturk96
Copy link
Collaborator

With latest master screenshot tests should work.

@Arthur-GYT
Copy link
Contributor Author

With latest master screenshot tests should work.

@alperozturk96

I have updated the branch

Signed-off-by: Arthur-GYT <a.gayot@posteo.com>
Signed-off-by: Arthur-GYT <a.gayot@posteo.com>
@Arthur-GYT
Copy link
Contributor Author

@alperozturk96
Copy link
Collaborator

Again ^^'

https://github.com/nextcloud/android/actions/runs/8879187564/job/24376356296?pr=12875

Unfortunately, our ss tests are not stable, sometimes need to re-run again to get successful output. We can try a couple of more time if it's still same, I guess we can force merge it.

@tobiasKaminsky

Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested successfully 👍

@AndyScherzinger AndyScherzinger merged commit 8a3135e into nextcloud:master Apr 30, 2024
20 checks passed
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.30.0 milestone Apr 30, 2024
@Arthur-GYT Arthur-GYT deleted the per-app-languages branch April 30, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants