Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Config With Restriction Manager #12884

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Apr 16, 2024

  • Tests written, or not not needed

Feature

Enterprise client can set proxy config

Listening app config changes reactively

Add new is_branded_plus option

What to Test

Drawer top bar visibility, assistant feature visibility due newly added is_branded_plus option

@alperozturk96 alperozturk96 force-pushed the feature/app-config branch 3 times, most recently from 8c10a68 to 6e74bf8 Compare April 18, 2024 15:27
@alperozturk96 alperozturk96 force-pushed the feature/app-config branch 2 times, most recently from 0247ab6 to 04a451a Compare April 26, 2024 14:06
Signed-off-by: alperozturk <alper_ozturk@proton.me>
…omer

Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Copy link

Codacy

Lint

TypemasterPR
Warnings7171
Errors33

SpotBugs

CategoryBaseNew
Bad practice6767
Correctness7272
Dodgy code341341
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness66
Performance5757
Security1919
Total572572

Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12884.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants