Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NullPointerException when invoking equals() on limitToPersonalFiles #12930

Merged
merged 2 commits into from
May 2, 2024
Merged

Fix NullPointerException when invoking equals() on limitToPersonalFiles #12930

merged 2 commits into from
May 2, 2024

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Apr 24, 2024 •
edited
Loading

  • Tests written, or not not needed

@alperozturk96 alperozturk96 linked an issue Apr 24, 2024 that may be closed by this pull request
Bug? #12908
Closed
@alperozturk96 alperozturk96 force-pushed the bugfix/limitToPersonalFiles-fix-null-string-equals-exception branch 2 times, most recently from 9727247 to 46b10f3 Compare April 29, 2024 06:51
@alperozturk96 alperozturk96 force-pushed the bugfix/limitToPersonalFiles-fix-null-string-equals-exception branch from 46b10f3 to 0581da4 Compare April 30, 2024 12:31
@alperozturk96
Fix NullPointerException when invoking equals() on null String reference
0c1e2bc 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Fix code analytics
115d033 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 force-pushed the bugfix/limitToPersonalFiles-fix-null-string-equals-exception branch from 0581da4 to 115d033 Compare May 2, 2024 06:56
@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12930.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

Codacy

Lint

TypemasterPR
Warnings7272
Errors33

SpotBugs

CategoryBaseNew
Bad practice6767
Correctness7272
Dodgy code341341
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness66
Performance5757
Security1919
Total572572

@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/12930-Screenshot-blue-Light-07-28

@tobiasKaminsky tobiasKaminsky merged commit 30b5a4c into master May 2, 2024
17 of 21 checks passed
@delete-merged-branch delete-merged-branch bot deleted the bugfix/limitToPersonalFiles-fix-null-string-equals-exception branch May 2, 2024 13:33
@joshtrichards joshtrichards added this to the Nextcloud App 3.30.0 milestone Jun 13, 2024
@joshtrichards joshtrichards mentioned this pull request Jun 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes

@JonasMayerDev JonasMayerDev Awaiting requested review from JonasMayerDev

@AndyScherzinger AndyScherzinger Awaiting requested review from AndyScherzinger

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
Nextcloud App 3.30.0
Development

Successfully merging this pull request may close these issues.

Bug?
3 participants
@alperozturk96 @tobiasKaminsky @joshtrichards