Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix E2E File Deletion For V1 #12942

Merged
merged 8 commits into from May 2, 2024
Merged

Bugfix E2E File Deletion For V1 #12942

merged 8 commits into from May 2, 2024

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Apr 26, 2024

  • Tests written, or not not needed

How to Test

  1. Create encrypted folder
  2. Upload multiple files inside encrypted folder
  3. Delete one file from encrypted folder
  4. Refresh folder, file must be deleted
  5. Try to add some file again, file conflict notification should't appear

Test it for V1 (Nextcloud 27.1.7) and V2 (v28 and above)

Note

E2E version must be lower than 2.0

@alperozturk96 alperozturk96 linked an issue Apr 26, 2024 that may be closed by this pull request
4 tasks
@alperozturk96 alperozturk96 changed the title Bugfix E2E File Deletion Bugfix E2E File Deletion For V1 Apr 26, 2024
@alperozturk96 alperozturk96 force-pushed the bugfix/delete-file-v1 branch 3 times, most recently from 2c865dc to 11fd086 Compare May 2, 2024 06:55
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Copy link

github-actions bot commented May 2, 2024

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12942.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Copy link

github-actions bot commented May 2, 2024

Codacy

Lint

TypemasterPR
Warnings7272
Errors33

SpotBugs

CategoryBaseNew
Bad practice6767
Correctness7272
Dodgy code341341
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness66
Performance5757
Security1919
Total572572

@tobiasKaminsky
Copy link
Member

tobiasKaminsky commented May 2, 2024

Approved, restarted CI as "rename" test failed.

@alperozturk96 alperozturk96 merged commit 56d9327 into master May 2, 2024
21 checks passed
@delete-merged-branch delete-merged-branch bot deleted the bugfix/delete-file-v1 branch May 2, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete Functionality Not Working When Folder Encrypted For V1
2 participants