Added direct upload from video camera

[timedin-de]

Regarding feature request #7358

• Adding Option to directly upload a video

• If camera permissions are not already granted, it will ask if for video or image after granting (its seems not not to be possible to get the camera-action after the permission request)

• It seems that the videointent doesn't work on emulator?

• Tested successfull with a real GooglePixel 6a

• Tests written, or not not needed

• Update screenshots (DialogFragmentIT_testBottomSheet.png)

[alperozturk96]

Thanks for the contribution.

I try to upload video directly on Android 14 emulator, after completing video shooting upload didn't work. The video file didn't upload.

After my second attempt, the app is crashed. Logcat didn't show any crash log for nextcloud package and general android

Could you test via Android 14 emulator and share your findings with us?

[timedin-de]

Thanks for the contribution.

I try to upload video directly on Android 14 emulator, after completing video shooting upload didn't work. The video file didn't upload.

After my second attempt, the app is crashed. Logcat didn't show any crash log for nextcloud package and general android

Could you test via Android 14 emulator and share your findings with us?

Thanks for testing, thats what i meant with "It seems that the videointent doesn't work on emulator?", I tried countless times using the videointent on an emulator and it crashes or exits. I currently have no idea why this happens. On a hardware phone (Pixel 6a) it just works... (i was unsure if it was maybe just my underpowered laptop, but this ensures the bug)

I'll try some tests with only video intents (outside of the nextcloup app) on emulator to check for the issue.

[timedin-de]

Hey, I'm sorry, but I currently don't have the time (and motivation) to further check on this issue in the emulator. Maybe someone else finds the problem, or just discard the PR?

[alperozturk96]

Hey, I'm sorry, but I currently don't have the time (and motivation) to further check on this issue in the emulator. Maybe someone else finds the problem, or just discard the PR?

I'll check it. Thank you for your contribution; it's wonderful to see support from the community 👍

[JonasMayerDev]

For me, the PR seems to work on real device (One Plus running Android 12).

[JonasMayerDev]

What do you think of not having 2 different "upload from camera" in the Dialog Fragment but just one and then showing the user the dialog that's currently shown when accepting the permissions with the options video and image? I think the DialogFragment is already a little crowded, and it would make the experience a little more consistent since the dialog is currently only shown once regardless if "upload from camera" or "upload from video camera" is clicked...

@alperozturk96 @timedin-de What do you think?

[timedin-de]

@timedin-de What do you think?

Yep I could do it this way if you agree on it.
It would mean one more click to open the camera, but i think would cause less confusion, (especially the current additional prompt after the permission granting).

I chose the current approach because of the comment in the issue
by @joshtrichards in #7358 (comment)

[JonasMayerDev]

@timedin-de thank you! I guess the best persons to decide on that is the design team @nextcloud/designers
To summarize for them:

Option 1 for adding a "capture video" implementation would look something like this:

Pro: One click video capture
Con: Too crowded dialog when clicking plus button, Inconsistent since dialog from option 2 would still show once when accepting video permissions.

Option 2 would look something like this:

Pro: Consistent, less crowded
Con: 2 Clicks for video capture

[szaimen]

Honestly I dont unterstand what is the difference between upload from camera and upload from video camera?

[timedin-de]

Honestly I dont unterstand what is the difference between upload from camera and upload from video camera?

On Android when a camera gets started it needs to be specified if it should record a video or take a picture (you cant decide/change it inside of the camera preview).

So "video camera" starts in video-recording-mode, "camera" in photo-mode

[szaimen]

I see. Then maybe rename the entries to Take a video and upload and Take a photo and upload ?

[JonasMayerDev]

@szaimen Yes good point. But the question is if we should even use 2 separate buttons (video and image) when clicking on the plus in the app. Or if we combine it in one button and the ask the user in a dialog if he wants video or image (prefered option for me and Alper). Take a look at my message for the pro and cons in my opinion: #12995 (comment)

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!