Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check FragmentManager Before commit new FragmentTransaction #13038

Merged
merged 1 commit into from
May 29, 2024
Merged

Check FragmentManager Before commit new FragmentTransaction #13038

merged 1 commit into from
May 29, 2024

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented May 24, 2024 •
edited
Loading

  • Tests written, or not not needed

@alperozturk96
Check fragment manager before commit new FragmentTransaction
e1357cf 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 linked an issue May 24, 2024 that may be closed by this pull request
Some crash while downloading video #12971
Closed
4 tasks
@github-actions GitHub Actions
Copy link

Codacy

Lint

TypemasterPR
Warnings7171
Errors33

SpotBugs

CategoryBaseNew
Bad practice6464
Correctness6969
Dodgy code346346
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness66
Performance5757
Security1919
Total571571

@github-actions GitHub Actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13038.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

JonasMayerDev
JonasMayerDev approved these changes May 29, 2024
View reviewed changes
Copy link
Collaborator

@JonasMayerDev JonasMayerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't reproduce crash, but app still works fine and code looks good

@alperozturk96 alperozturk96 merged commit 50b5cc5 into master May 29, 2024
22 checks passed
@delete-merged-branch delete-merged-branch bot deleted the bugfix/setLeftFragment-fragmentManager-has-been-destroyed branch May 29, 2024 18:31
@alperozturk96
Copy link
Collaborator Author

/backport to stable-3.29

@backportbot backportbot bot mentioned this pull request Jun 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonasMayerDev JonasMayerDev JonasMayerDev approved these changes

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some crash while downloading video
2 participants
@alperozturk96 @JonasMayerDev