Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(files): "Create new" -> "New" #13039

Merged
merged 2 commits into from
May 27, 2024
Merged

fix(files): "Create new" -> "New" #13039

merged 2 commits into from
May 27, 2024

Conversation

joshtrichards
Copy link
Member

@joshtrichards joshtrichards commented May 24, 2024 •
edited by AndyScherzinger
Loading

  • Align with web UI
  • Reduce screen footprint
  • More concise
  • Tests written, or not not needed

@joshtrichards
Copy link
Member Author

Screenshot test failure to be expected.

joshtrichards and others added 2 commits May 27, 2024 09:51
@joshtrichards @AndyScherzinger
fix(files): "Create new" -> "New"
2ea33b5 
* Align with web UI
* Reduce screen footprint
* More concise

Signed-off-by: Josh <josh.t.richards@gmail.com>
@AndyScherzinger
chore: update screenshot
6eb9a28 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
Copy link
Member

Screenshot test failure to be expected.

Fixed via 6eb9a28

@AndyScherzinger
Copy link
Member

/backport to stable-3.29

@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.30.0 milestone May 27, 2024
@AndyScherzinger AndyScherzinger merged commit 7ce1bb5 into master May 27, 2024
20 of 21 checks passed
@delete-merged-branch delete-merged-branch bot deleted the jtr/fix-files-create-new branch May 27, 2024 07:58
@backportbot backportbot bot mentioned this pull request May 27, 2024
Merged
@github-actions GitHub Actions
Copy link

Codacy

Lint

TypemasterPR
Warnings7171
Errors33

SpotBugs

CategoryBaseNew
Bad practice6464
Correctness6969
Dodgy code346346
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness66
Performance5757
Security1919
Total571571

@github-actions GitHub Actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13039.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 8, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@JonasMayerDev JonasMayerDev Awaiting requested review from JonasMayerDev

@ZetaTom ZetaTom Awaiting requested review from ZetaTom

Assignees
No one assigned
Labels
3. to review bug feature: files feedback-requested
Projects
None yet
Milestone
Nextcloud App 3.30.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joshtrichards @AndyScherzinger