Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): Use "favorites" versus "favourites" consistently #13041

Merged
merged 1 commit into from
May 27, 2024

Conversation

joshtrichards
Copy link
Member

  • Tests written, or not not needed

Signed-off-by: Josh <josh.t.richards@gmail.com>
Copy link

Codacy

Lint

TypemasterPR
Warnings7171
Errors33

SpotBugs

CategoryBaseNew
Bad practice6464
Correctness6969
Dodgy code346346
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness66
Performance5757
Security1919
Total571571

Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13041.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Copy link

@AndyScherzinger
Copy link
Member

/backport to stable-3.29

@AndyScherzinger AndyScherzinger merged commit 1bce9e5 into master May 27, 2024
17 of 21 checks passed
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.30.0 milestone May 27, 2024
@delete-merged-branch delete-merged-branch bot deleted the jtr/fix-favorites-vs-favourites branch May 27, 2024 07:55
Copy link

github-actions bot commented Jun 8, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants