Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix State Loss Crash For SyncedFolderPreferencesDialogFragment #13070

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Jun 5, 2024

  • Tests written, or not not needed

Signed-off-by: alperozturk <alper_ozturk@proton.me>
Copy link

github-actions bot commented Jun 5, 2024

Codacy

Lint

TypemasterPR
Warnings7070
Errors33

SpotBugs

CategoryBaseNew
Bad practice6464
Correctness6969
Dodgy code346346
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness66
Performance5757
Security1919
Total571571

Copy link

github-actions bot commented Jun 5, 2024

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13070.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.

Project coverage is 26.62%. Comparing base (8d78cd7) to head (f2b0593).

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13070      +/-   ##
============================================
+ Coverage     26.54%   26.62%   +0.07%     
- Complexity     3319     3330      +11     
============================================
  Files           638      638              
  Lines         46927    46932       +5     
  Branches       6144     6146       +2     
============================================
+ Hits          12458    12496      +38     
+ Misses        32622    32604      -18     
+ Partials       1847     1832      -15     
Files Coverage Δ
...ui/dialog/SyncedFolderPreferencesDialogFragment.kt 0.00% <0.00%> (ø)
...cloud/android/ui/activity/SyncedFoldersActivity.kt 20.82% <0.00%> (-0.18%) ⬇️

... and 19 files with indirect coverage changes

@tobiasKaminsky tobiasKaminsky merged commit 705ba71 into master Jun 5, 2024
22 of 23 checks passed
@delete-merged-branch delete-merged-branch bot deleted the bugfix/fix-state-loss-crash-on-SyncedFolderPreferencesDialogFragment branch June 5, 2024 13:56
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.30.0 milestone Jun 5, 2024
@alperozturk96
Copy link
Collaborator Author

/backport to stable-3.29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants