Fix Wrong Context Usage #13080
Merged
Fix Wrong Context Usage #13080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: github-actions <github-actions@github.com>
alperozturk96
force-pushed
the
bugfix/wrong-context-usage
branch
from
ec9eef7
to
26dbc09
Compare
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13080.apk |
tobiasKaminsky
approved these changes
Jun 7, 2024
|
/backport to stable-3.29 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does?
If minSdkVersion is higher than 21, multidex is enabled by default and no need to have multidex library. Documentation
Context usage in MainApp.java may cause memory leak therefore WeakReference used
context sometimes can be null at UserAccountManagerImpl.createUserFromAccount() if context is null MainApp.context used