Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Preview Image Activity to Kotlin #13157

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Jun 20, 2024

  • Tests written, or not not needed

Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 force-pushed the refactor/convert-preview-image-activity-to-kt branch from bae4a6c to 85aab26 Compare June 25, 2024 07:21
Copy link

Codacy

Lint

TypemasterPR
Warnings6868
Errors33

SpotBugs

CategoryBaseNew
Bad practice6464
Correctness6868
Dodgy code338333
Experimental11
Internationalization77
Multithreaded correctness66
Performance5757
Security1818
Total559554

Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13157.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@alperozturk96 alperozturk96 merged commit 7c71486 into master Jun 25, 2024
21 checks passed
@AndyScherzinger AndyScherzinger deleted the refactor/convert-preview-image-activity-to-kt branch June 25, 2024 11:30
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.30.0 milestone Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants