Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use preview endpoint instead of thumbnail #13164

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Jun 21, 2024

do not use path, but fileid for previews

  • Tests written, or not not needed

do not use path, but fileid for previews

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Copy link

test-Unit test failed, but no output was generated. Maybe a preliminary stage failed.

Copy link

Codacy

Lint

TypemasterPR
Warnings6868
Errors33

SpotBugs

CategoryBaseNew
Bad practice6464
Correctness6868
Dodgy code338338
Experimental11
Internationalization77
Multithreaded correctness66
Performance5757
Security1818
Total559559

Copy link
Collaborator

@alperozturk96 alperozturk96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested working

@AndyScherzinger
Copy link
Member

should we check that the id is not -1 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants