Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix dav4jvm checksum #13165

Merged
merged 1 commit into from
Jun 24, 2024
Merged

fix dav4jvm checksum #13165

merged 1 commit into from
Jun 24, 2024

Conversation

tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Jun 21, 2024 •
edited by AndyScherzinger
Loading

  • Tests written, or not not needed

@tobiasKaminsky
Copy link
Member Author

/backport to stable-3.29

@tobiasKaminsky tobiasKaminsky force-pushed the fixDav4vjmChecksum branch 2 times, most recently from 4bec548 to 30f5419 Compare June 21, 2024 06:55
@tobiasKaminsky
Copy link
Member Author

@AndyScherzinger https://github.com/bitfireAT/dav4jvm/releases/tag/2.2.1
they did not changed their files…
Maybe it is maven specific problem?
Not sure, how to proceed?

Same with lib: nextcloud/android-library#1483

@tobiasKaminsky @AndyScherzinger
fix dav4jvm checksum
1790a06 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@github-actions GitHub Actions
Copy link

Codacy

Lint

TypemasterPR
Warnings6868
Errors33

SpotBugs

CategoryBaseNew
Bad practice6464
Correctness6868
Dodgy code338338
Experimental11
Internationalization77
Multithreaded correctness66
Performance5757
Security1818
Total559559

@github-actions GitHub Actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13165.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@AndyScherzinger
Copy link
Member

yeah for some reason the release artifacts were gone from jitpack, and I was magically able to re-trigger it by calling the right jitpack URLs which than recreated the artifacts. I expect the artifacts are hence slightly different in terms of checksums because jitpack uses the latest version of the pinned major java version.

@github-actions GitHub Actions
Copy link

blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/13165-Screenshot-blue-Light-12-20

@tobiasKaminsky tobiasKaminsky merged commit 5f88681 into master Jun 24, 2024
19 of 21 checks passed
@backportbot backportbot bot mentioned this pull request Jun 24, 2024
Merged
@AndyScherzinger AndyScherzinger mentioned this pull request Jun 24, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tobiasKaminsky @AndyScherzinger