Share Link Crash Fix #13166
Merged
Share Link Crash Fix #13166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
alperozturk96
force-pushed
the
crash-fix-share-link
branch
from
db7db6f
to
3f89c24
Compare
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
alperozturk96
force-pushed
the
crash-fix-share-link
branch
from
22506ee
to
66f0da3
Compare
Signed-off-by: alperozturk <alper_ozturk@proton.me>
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13166.apk |
AndyScherzinger
approved these changes
Jun 28, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
After share file list needs to be updated for the display the share icon on the folder. Sometimes a folder cannot be found after share action.
Solution
We can prevent crash via checking file existence and check Share Object instance type. If we cannot find file in the list we can inform the user.
During my tests, share functionality is working as expected. I can't able to reproduce.
Screen.Recording.2024-06-21.at.15.46.25.mp4