Replace text field #2022
Merged
Replace text field #2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -29,32 +28,26 @@ | |||
| android:id="@+id/encryption_status" | |||
| android:layout_width="match_parent" | |||
| android:layout_height="wrap_content" | |||
| android:layout_margin="10dp"/> | |||
| android:layout_margin="10dp" /> | |||
There was a problem hiding this comment.
can you raise this to 16dp (standard_margin)?
|
👍 just a minor comment |
tobiasKaminsky
force-pushed
the
replaceTextField
branch
from
4080b26
to
8264d2a
Compare
|
Nice, cc @mario for review :) |
AndyScherzinger
force-pushed
the
replaceTextField
branch
2 times, most recently
from
7443ea5
to
50b431b
Compare
Signed-off-by: tobiaskaminsky <tobias@kaminsky.me>
AndyScherzinger
force-pushed
the
replaceTextField
branch
from
50b431b
to
d7cfbff
Compare
|
@mario last one for today - I promise :D |
|
Can we please use Butterknife for all the views? Thanks! |
|
We can, for new screens or as an enhancement for next milestone(s). |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2007
Signed-off-by: tobiaskaminsky tobias@kaminsky.me