Show sharees

[tobiasKaminsky]

Needs: nextcloud/server#14429

TODO

• backward compability NC<17: no sharees available, thus show old "share" icon
• test
  • NC master + Show sharees via propfind server#14429 need same "share indicator" as NC15 (share icon on old vs. avatar on new)
• federated share
  • show avatar for incoming share
  • show avatar for sharing a file to a remote user

Federated sharing is out of scope. This needs to be done first on server: nextcloud/server#14564

What it does

• show avatars
  • of person who shared it with me on first position (left) [if any]
  • shows list of persons I shared with (if any)
  • limit is 3: if more than 3 it shows "multiple user icon"
  • click on it still opens share view

Special thanks to @stefan-niedermann @desperateCoder for helping with the overlapping avatars!

[desperateCoder]

@tobiasKaminsky you're welcome buddy! 😃

[codecov]

Codecov Report

Merging #3765 into master will increase coverage by <.01%.
The diff coverage is 4.7%.

@@             Coverage Diff             @@
##             master   #3765      +/-   ##
===========================================
+ Coverage      6.31%   6.31%   +<.01%     
  Complexity        1       1              
===========================================
  Files           318     318              
  Lines         31212   31236      +24     
  Branches       4469    4472       +3     
===========================================
+ Hits           1971    1973       +2     
- Misses        28946   28968      +22     
  Partials        295     295

Impacted Files	Coverage Δ	Complexity Δ
...ain/java/com/owncloud/android/db/ProviderMeta.java	88% <ø> (ø)	0 <0> (ø)	⬇️
...loud/android/datamodel/ThumbnailsCacheManager.java	15.08% <ø> (ø)	0 <0> (ø)	⬇️
...ncloud/android/ui/fragment/FileDetailFragment.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...a/com/owncloud/android/utils/FileStorageUtils.java	8% <0%> (ø)	0 <0> (ø)	⬇️
...cloud/android/ui/adapter/FileDetailTabAdapter.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...owncloud/android/ui/adapter/OCFileListAdapter.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...wncloud/android/providers/FileContentProvider.java	18.9% <0%> (ø)	0 <0> (ø)	⬇️
...android/ui/fragment/FileDetailSharingFragment.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...in/java/com/owncloud/android/datamodel/OCFile.java	59.36% <100%> (ø)	0 <0> (ø)	⬇️
...loud/android/datamodel/FileDataStorageManager.java	11.84% <42.85%> (+0.05%)	0 <0> (ø)	⬇️
... and 10 more

[codecov]

Codecov Report

Merging #3765 into master will decrease coverage by 0.17%.
The diff coverage is 4.54%.

@@             Coverage Diff             @@
##             master   #3765      +/-   ##
===========================================
- Coverage      6.57%    6.4%   -0.18%     
  Complexity        1       1              
===========================================
  Files           320     323       +3     
  Lines         30814   31295     +481     
  Branches       4403    4481      +78     
===========================================
- Hits           2027    2005      -22     
- Misses        28492   28992     +500     
- Partials        295     298       +3

Impacted Files	Coverage Δ	Complexity Δ
...ncloud/android/ui/fragment/FileDetailFragment.java	0% <ø> (ø)	0 <0> (ø)	⬇️
...ain/java/com/owncloud/android/db/ProviderMeta.java	84.61% <ø> (ø)	0 <0> (ø)	⬇️
...loud/android/datamodel/ThumbnailsCacheManager.java	15.08% <ø> (ø)	0 <0> (ø)	⬇️
...a/com/owncloud/android/utils/FileStorageUtils.java	7.96% <0%> (-0.04%)	0 <0> (ø)
...owncloud/android/ui/adapter/OCFileListAdapter.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...wncloud/android/providers/FileContentProvider.java	18.68% <0%> (-0.22%)	0 <0> (ø)
...android/ui/fragment/FileDetailSharingFragment.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...m/owncloud/android/ui/adapter/UserListAdapter.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...in/java/com/owncloud/android/datamodel/OCFile.java	59.54% <100%> (+0.18%)	0 <0> (ø)	⬇️
...loud/android/datamodel/FileDataStorageManager.java	11.96% <37.5%> (+0.17%)	0 <0> (ø)	⬇️
... and 85 more

[tobiasKaminsky]

AndyScherzinger force-pushed the showSharees branch from 3df3a0c to 88bc211 a day ago

Please do not do a force-push on branches we are developing on, as this breaks the locally checked out branch. It makes it especially hard, when the other person has uncommitted changes.
A merge master should be the way to go while developing.

Once it is ready we can and should do a rebase on master to get rid of those merge commits.

[tobiasKaminsky]

NC master:
Android

Server:

[AndyScherzinger]

@tobiasKaminsky is the difference between Android and webUI on purpose?

[tobiasKaminsky]

@tobiasKaminsky is the difference between Android and webUI on purpose?

Yes, we are the future :-)

• show avatars for federated sharing
• show multiple avatars

[tobiasKaminsky]

NC 15:

Android:

Server:

[tobiasKaminsky]

So this is ready from my side, but we will have to wait for server.

[AndyScherzinger]

👍 looks good code-wise, just a question, and an unused import it seems

[tobiasKaminsky]

I am unsure, if we wait for linked server PR, or just merge this and once server PR is ready, this will work out of the box…

[AndyScherzinger]

@tobiasKaminsky if it won't lead to issues/crashes without the server merge and then works automagially as soon as the server supports it then I'd say let's merge it.

[nextcloud-android-bot]

Codacy

298

Lint

Type	master	PR
Warnings	57	57
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	25
Correctness Warnings	80
Internationalization Warnings	15
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	9
Performance Warnings	124
Security Warnings	47
Dodgy code Warnings	132
Total	436

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	25
Correctness Warnings	80
Internationalization Warnings	15
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	9
Performance Warnings	124
Security Warnings	47
Dodgy code Warnings	132
Total	436

[nextcloud-android-bot]

IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/8826