-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show sharees #3765
Show sharees #3765
Conversation
@tobiasKaminsky you're welcome buddy! 😃 |
756a3b9
to
77610af
Compare
77610af
to
ac71ec1
Compare
Codecov Report
@@ Coverage Diff @@
## master #3765 +/- ##
===========================================
+ Coverage 6.31% 6.31% +<.01%
Complexity 1 1
===========================================
Files 318 318
Lines 31212 31236 +24
Branches 4469 4472 +3
===========================================
+ Hits 1971 1973 +2
- Misses 28946 28968 +22
Partials 295 295
|
Codecov Report
@@ Coverage Diff @@
## master #3765 +/- ##
===========================================
- Coverage 6.57% 6.4% -0.18%
Complexity 1 1
===========================================
Files 320 323 +3
Lines 30814 31295 +481
Branches 4403 4481 +78
===========================================
- Hits 2027 2005 -22
- Misses 28492 28992 +500
- Partials 295 298 +3
|
ac71ec1
to
88c4d33
Compare
88c4d33
to
d28b7aa
Compare
d28b7aa
to
3df3a0c
Compare
3df3a0c
to
88bc211
Compare
Please do not do a force-push on branches we are developing on, as this breaks the locally checked out branch. It makes it especially hard, when the other person has uncommitted changes. Once it is ready we can and should do a rebase on master to get rid of those merge commits. |
@tobiasKaminsky is the difference between Android and webUI on purpose? |
Yes, we are the future :-)
|
So this is ready from my side, but we will have to wait for server. |
👍 looks good code-wise, just a question, and an unused import it seems |
I am unsure, if we wait for linked server PR, or just merge this and once server PR is ready, this will work out of the box… |
@tobiasKaminsky if it won't lead to issues/crashes without the server merge and then works automagially as soon as the server supports it then I'd say let's merge it. |
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
af7f2e0
to
dc7a2c0
Compare
Codacy298Lint
SpotBugs (new)
SpotBugs (master)
|
IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/8826 |
71f3370 Drone: update FindBugs results to reflect reduced error/warning count [skip ci] 0f50088 Merge pull request #3916 from jmue/cleanup/string_compare 7bb07a0 Update wording for store text (#3903) 4c72f3f Merge pull request #3923 from nextcloud/editOnShareLink 81ed32f allow edit on link share on a file 7d01ff7 - fix IT tests - re-organized build.gradle a bit a9afff7 Merge pull request #3929 from nextcloud/dependabot/gradle/org.powermock-powermock-core-2.0.2 71c6d99 bump all other powermock parts to 2.0.2 0421d26 Bump powermock-core from 2.0.0 to 2.0.2 1d28d1b Update with new wording from frontpage de3d3de Merge pull request #3924 from nextcloud/warnOnStable 69dd243 warn for wrong library branch on stable 2379b49 Merge pull request #3921 from nextcloud/dependabot/gradle/com.android.tools.build-gradle-3.4.0 c2730e8 Bump gradle from 3.3.2 to 3.4.0 b69169f unify empty string compare 8bb654b fix test & review comments d8b9d10 unify empty string compare 2f23a30 remove unused variable (#3920) 92df32e Merge pull request #3918 from nextcloud/codacyCleanup 091c003 Drone: update FindBugs results to reflect reduced error/warning count [skip ci] 15ec487 Drone: update FindBugs results to reflect reduced error/warning count [skip ci] da3c497 Merge commit '334155e707975e740a0a13b33d9b7bbedf40e9bc' b22f517 Merge pull request #3915 from jmue/cleanup/ocfile c7c6a98 use constant e6604c8 use constant caa2a91 Merge pull request #3912 from nextcloud/libraryUsage 334155e some cleanups 28f80cd Merge pull request #3907 from nextcloud/ezaquarii/initialize-main-app-context-before-content-providers-start 2afb934 Drone: update FindBugs results to reflect reduced error/warning count [skip ci] 8be1157 Merge pull request #3899 from jmue/cleanup/uriutils 52020a9 direct usage of library project 4062d40 Merge pull request #3908 from nextcloud/missingInjectable 2a08cb4 Initialize global context before MainApp.onCreate() f02f482 Missing Injectable lead to half-stored account 02cbafe Merge pull request #3765 from nextcloud/showSharees dc7a2c0 show sharees 03e04e5 Merge pull request #3889 from nextcloud/checkUserId d65e94b Update wording for store text 585a3d0 Drone: update FindBugs results to reflect reduced error/warning count [skip ci] 533debf - removed useNextcloudUserAgent -> we now use this everytime - removed any oAuth and saml stuff, as we rely on weblogin flow d544fa5 Merge pull request #3897 from nextcloud/ezaquarii/move-current-account-getter-to-user-account-manager 5b4ffba Merge pull request #3900 from nextcloud/codacyOnMaster 2757244 remove unused code 428a8bb show codacy count only on master 6b44074 Drone: update FindBugs results to reflect reduced error/warning count [skip ci] c62e89b Merge commit '442394f949ff2de86bcccae172d2e9d997ab2ef8' 442394f Migrate current account getter from AccountUtils to UserAccountManager 182b65e daily dev 20190414
Needs: nextcloud/server#14429
TODO
federated shareshow avatar for incoming shareshow avatar for sharing a file to a remote userFederated sharing is out of scope. This needs to be done first on server: nextcloud/server#14564
What it does
Special thanks to @stefan-niedermann @desperateCoder for helping with the overlapping avatars!