Remove onAccountSet from FolderPickerActivity #4689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR can be reviewed and testes. Mege requires merging #4677 first. |
tobiasKaminsky
force-pushed
the
account-cleanup-folder-picker-activity
branch
from
4e9fb42
to
f580ae8
Compare
|
And once again, rebased, tested, works 🎉 |
tobiasKaminsky
approved these changes
Oct 16, 2019
|
Thanks @ezaquarii for your great work! |
Codecov Report
@@ Coverage Diff @@
## master #4689 +/- ##
=========================================
Coverage ? 17.52%
Complexity ? 3
=========================================
Files ? 375
Lines ? 32123
Branches ? 4543
=========================================
Hits ? 5629
Misses ? 25588
Partials ? 906
|
Move onAccountSet body to onStart. Unconditionally reset fragment state, since the acctount restoration flag is no longer available. Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
ezaquarii
force-pushed
the
account-cleanup-folder-picker-activity
branch
from
f580ae8
to
3519d04
Compare
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11275.apk |
|
@tobiasKaminsky Ready for merge |
Codacy283Lint
SpotBugs (new)
SpotBugs (master)
|
7 tasks
delete-merged-branch
bot
deleted the
account-cleanup-folder-picker-activity
branch
tobiasKaminsky
added a commit
that referenced
this pull request
Oct 18, 2019
16cc46f Merge pull request #4687 from nextcloud/account-cleanup-upload-files-activity d9567a2 Merge pull request #4686 from nextcloud/account-cleanup-image-video-preview 2d9afe3 Merge pull request #4688 from nextcloud/account-cleanup-share-activity f4a27cc Merge pull request #4693 from nextcloud/account-cleanup-file-display-activity d237a83 Merge pull request #4699 from nextcloud/removeUploadPathActivity 64c986e Merge pull request #4689 from nextcloud/account-cleanup-folder-picker-activity 56d1880 Bump powermock-core from 2.0.2 to 2.0.4 (#4695) ca77c7a Bump powermock-api-mockito2 from 2.0.2 to 2.0.4 (#4696) baaf5d4 Bump powermock-module-junit4 from 2.0.2 to 2.0.4 (#4697) ab904e3 We do not use UploadPathActivity anymore(?) 9773dc4 Merge pull request #4694 from nextcloud/account-cleanup-conflicts-resolve-activity ae6cfb3 daily dev 20191017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move onAccountSet body to onStart.
Unconditionally reset fragment state, since the
acctount restoration flag is no longer available.
Signed-off-by: Chris Narkiewicz hello@ezaquarii.com