Remove onAccountSet from ReceiveExternalFilesActivity

[ezaquarii]

1. onAccountSet logic inlined in onStart and changeAccount
2. call to onAccountSet eliminated

Signed-off-by: Chris Narkiewicz hello@ezaquarii.com

[ezaquarii]

This flag from BaseActivity is not modified in the subclass so it's safe to remove it.

[nextcloud-android-bot]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11323.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[nextcloud-android-bot]

Codacy

299

Lint

Type	master	PR
Warnings	59	59
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	26
Correctness Warnings	69
Internationalization Warnings	12
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	9
Performance Warnings	120
Security Warnings	44
Dodgy code Warnings	138
Total	422

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	26
Correctness Warnings	69
Internationalization Warnings	12
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	9
Performance Warnings	120
Security Warnings	44
Dodgy code Warnings	138
Total	422

[codecov]

Codecov Report

Merging #4700 into master will increase coverage by 0.13%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #4700      +/-   ##
============================================
+ Coverage     17.51%   17.64%   +0.13%     
  Complexity        3        3              
============================================
  Files           374      374              
  Lines         32101    32102       +1     
  Branches       4541     4541              
============================================
+ Hits           5621     5663      +42     
+ Misses        25569    25530      -39     
+ Partials        911      909       -2

Impacted Files	Coverage Δ	Complexity Δ
...roid/ui/activity/ReceiveExternalFilesActivity.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...oud/android/ui/activity/SyncedFoldersActivity.java	22.79% <0%> (ø)	0% <0%> (ø)	⬇️
...cloud/android/ui/activity/FileDisplayActivity.java	20.25% <0%> (+0.24%)	0% <0%> (ø)	⬇️
...ncloud/android/ui/fragment/OCFileListFragment.java	25.57% <0%> (+0.27%)	0% <0%> (ø)	⬇️
...xtcloud/client/preferences/AppPreferencesImpl.java	54.03% <0%> (+0.62%)	0% <0%> (ø)	⬇️
...loud/android/datamodel/ThumbnailsCacheManager.java	36.31% <0%> (+0.72%)	0% <0%> (ø)	⬇️
.../java/com/owncloud/android/utils/DisplayUtils.java	25.73% <0%> (+0.84%)	0% <0%> (ø)	⬇️
.../third_parties/daveKoeller/AlphanumComparator.java	83.33% <0%> (+1.19%)	0% <0%> (ø)	⬇️
...owncloud/android/ui/adapter/OCFileListAdapter.java	30.72% <0%> (+1.71%)	0% <0%> (ø)	⬇️
...om/owncloud/android/utils/FileSortOrderByName.java	17.14% <0%> (+2.85%)	0% <0%> (ø)	⬇️
... and 5 more