Added new restore icon (to replace the small one)

[Kilian-Perisset]

Fixing issue : #4848

[tobiasKaminsky]

Once you think the PR is good for review, please add "2. to review" as label.

[tobiasKaminsky]

As you are a member, you can also push a branch / PR directly to our nextcloud repo.
This makes reviewing a bit easier for the other contributors :-)

[tobiasKaminsky]

Thank you for your PR.
How it looks like:

How the restore button of web ui looks like:

How it previously looked:

Can you try to re-use the old icon, but make it bigger?
Original svg logo can be found here: https://github.com/nextcloud/android/blob/f8801115f2f9a27b6da52aaf5b1c36940b1f2652/drawable_resources/history.svg

[Kilian-Perisset]

@tobiasKaminsky

Thanks for these advices and guidelines
In my opinion, I find the icon too "bold" :

But I may apply this one if you want to.

[AndyScherzinger]

@jancborchardt can you comment on the @nextcloud/designers preference regarding the icon? (Last two comments). Thanks ❤️

[Kilian-Perisset]

@AndyScherzinger @tobiasKaminsky
It would be a pleasure to push on your repository, except that I don't really understand the relationship between the guidelines and the current situation of the repo branches.

I'm very motivated to help you improve this application, but these branches don't really motivate to do the things properly (since the order is not very present)

Don't you want help to clean up the branches and issues so that we can have a proper and workeable project to work on ?

[jancborchardt]

Yep, the current icon is indeed too thick, thanks for looking into that @Shagequi

Is this a Material design icon? If not, can we pick one from Material icons?
Cause it seems a bit big and thin now, and the arrow is not so visible.
And then could you also do a pull request for server to replace the icon in core/img/actions so it is consistent – thanks a lot! :)

@Shagequi regarding branches:
You are a member of the Nextcloud github org, so you do not need a fork. Simply create a branch on this repository, like you did on your fork.
That way if changes are needed, other collaborators can do those too.
Master is the main branch and everything else are feature branches (pull requests). Do you mean there are a lot of outdates branches lying around which should be cleaned up?

[jancborchardt]

(This is off-topic, but to clean up branches, a good starting point is to go through the stale branches and delete those not needed anymore: https://github.com/nextcloud/android/branches/stale :)

[tobiasKaminsky]

Is this a Material design icon? If not, can we pick one from Material icons?

I thought I picked it up from server repo? 🤔

[tobiasKaminsky]

@Shagequi let us have this discussion in a new ticket please.
@jancborchardt you should know it better and not start off topic here!

[AndyScherzinger]

Is this a Material design icon? If not, can we pick one from Material icons?

It is looking like one (but isn't), while I would suggest:
https://materialdesignicons.com/icon/replay

What do you think @jancborchardt @tobiasKaminsky @Shagequi ?

I thought I picked it up from server repo? 🤔

You did, and the server's icon is not a material design icon

[Kilian-Perisset]

@AndyScherzinger I approve this icon, more visible :)

[tobiasKaminsky]

I am fine with this material icon, but what about @jancborchardt ?

[jancborchardt]

Yes, the icon was correctly picked from the server repo. :) However @Shagequi is right that the server icon is too bold. Which is why I said above:

And then could you also do a pull request for server to replace the icon in core/img/actions so it is consistent – thanks a lot! :)

And yes, the Material replay icon looks good!

[tobiasKaminsky]

@Shagequi is this really the material icon? For me it looks somehow the same like the old one…?

[nextcloud-android-bot]

IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/11731

[Kilian-Perisset]

@tobiasKaminsky

Here is the difference between the two icons :

NextCloud :

My version :

Unless I'm mistaken, the one I propose has been redesigned by one of our UI designer.
So it's based on Material.

[tobiasKaminsky]

It is looking like one (but isn't), while I would suggest:
https://materialdesignicons.com/icon/replay

What do you think @jancborchardt @tobiasKaminsky @Shagequi ?

I thought I picked it up from server repo? thinking

You did, and the server's icon is not a material design icon

Andy suggested the one by Android's material design and Jan approved it, so please use this one.

[AndyScherzinger]

Andy suggested the one by Android's material design and Jan approved it, so please use this one.

@Shagequi would yoou replace it within this PR or should I? (fine either way) 😃

[Kilian-Perisset]

@AndyScherzinger Yes I will replace the icon today :)

[AndyScherzinger]

[Kilian-Perisset]

The branch has been updated

[nextcloud-android-bot]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11783.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[nextcloud-android-bot]

Codacy

333

Lint

Type	master	PR
Warnings	59	59
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	26
Correctness Warnings	70
Internationalization Warnings	13
Malicious code vulnerability Warnings	5
Multithreaded correctness Warnings	9
Performance Warnings	104
Security Warnings	44
Dodgy code Warnings	136
Total	407

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	26
Correctness Warnings	70
Internationalization Warnings	13
Malicious code vulnerability Warnings	5
Multithreaded correctness Warnings	9
Performance Warnings	104
Security Warnings	44
Dodgy code Warnings	136
Total	407

[codecov]

Codecov Report

Merging #4865 into master will increase coverage by 0.09%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4865      +/-   ##
============================================
+ Coverage      17.6%   17.69%   +0.09%     
  Complexity        3        3              
============================================
  Files           377      384       +7     
  Lines         32403    32650     +247     
  Branches       4580     4597      +17     
============================================
+ Hits           5704     5779      +75     
- Misses        25780    25945     +165     
- Partials        919      926       +7

Impacted Files	Coverage Δ	Complexity Δ
.../java/com/owncloud/android/utils/DisplayUtils.java	23.62% <0%> (-1.27%)	0% <0%> (ø)
.../third_parties/daveKoeller/AlphanumComparator.java	80.95% <0%> (-1.2%)	0% <0%> (ø)
...om/nextcloud/client/network/ClientFactoryImpl.java	36.36% <0%> (-1.14%)	0% <0%> (ø)
...xtcloud/client/account/UserAccountManagerImpl.java	48.92% <0%> (-1.08%)	0% <0%> (ø)
...ncloud/android/ui/adapter/SyncedFolderAdapter.java	13.14% <0%> (-1%)	0% <0%> (ø)
...tcloud/client/network/ConnectivityServiceImpl.java	58.33% <0%> (-0.99%)	0% <0%> (ø)
...com/owncloud/android/ui/activity/BaseActivity.java	30.33% <0%> (-0.62%)	0% <0%> (ø)
...owncloud/android/ui/activity/SettingsActivity.java	38.46% <0%> (-0.25%)	0% <0%> (ø)
...wncloud/android/providers/FileContentProvider.java	21.6% <0%> (-0.24%)	0% <0%> (ø)
...ncloud/android/datamodel/SyncedFolderProvider.java	11.66% <0%> (-0.2%)	0% <0%> (ø)
... and 45 more

[AndyScherzinger]

@tobiasKaminsky @jancborchardt see screenshot, fine from my pov, please merge after final review :)

[jancborchardt]

Looks good! :)

[tobiasKaminsky]

Thanks for your PR @Shagequi 🎉

[jancborchardt]

Good stuff @Shagequi! :) As mentioned above, could you also open a pull request to change the same in the server:
https://github.com/nextcloud/server/blob/master/core/img/actions/history.svg
(There’s also a .png version of it.)

Just make sure it’s the same dimensions, and that it’s compressed. You can compress SVG with the scour command in this script: https://github.com/nextcloud/server/blob/master/build/image-optimization.sh#L10