Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #4955 #4956

Merged
merged 1 commit into from
Dec 6, 2019
Merged

fix #4955 #4956

merged 1 commit into from
Dec 6, 2019

Conversation

tobiasKaminsky
Copy link
Member

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11885.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

Codacy

325

Lint

TypemasterPR
Warnings5959
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings70
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings104
Security Warnings44
Dodgy code Warnings136
Total407

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings70
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings104
Security Warnings44
Dodgy code Warnings136
Total407

@codecov
Copy link

codecov bot commented Dec 6, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@d8722b5). Click here to learn what that means.
The diff coverage is 33.33%.

@@           Coverage Diff            @@
##             master   #4956   +/-   ##
========================================
  Coverage          ?   17.7%           
  Complexity        ?       3           
========================================
  Files             ?     385           
  Lines             ?   32665           
  Branches          ?    4592           
========================================
  Hits              ?    5782           
  Misses            ?   25957           
  Partials          ?     926
Impacted Files Coverage Δ Complexity Δ
...owncloud/android/ui/activity/SettingsActivity.java 39.38% <33.33%> (ø) 0 <0> (?)

@AndyScherzinger AndyScherzinger merged commit f9bd91b into master Dec 6, 2019
@delete-merged-branch delete-merged-branch bot deleted the fixScreenshot branch December 6, 2019 09:21
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.10.0 milestone Dec 6, 2019
tobiasKaminsky added a commit that referenced this pull request Dec 7, 2019
f9bd91b Merge pull request #4956 from nextcloud/fixScreenshot
d95351b Merge pull request #4953 from nextcloud/dependabot/gradle/io.gitlab.arturbosch.detekt-detekt-gradle-plugin-1.2.2
3ed9ce2 Merge pull request #4920 from nextcloud/theming_server_input
b01f719 fix #4955
01e5329 fix #4752
d8722b5 [tx-robot] updated from transifex
ed52ad5 daily dev 20191206
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants