Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort/list change for ReceiveExternalFilesActivity.java #6193

Merged
merged 1 commit into from Jun 4, 2020
Merged

Sort/list change for ReceiveExternalFilesActivity.java #6193

merged 1 commit into from Jun 4, 2020

Conversation

tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Jun 2, 2020 •
edited

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

Testing

Writing tests is very important. Please try to write some tests for your PR.
If you need help, please do not hesitate to ask in this PR for help.

unit tests
instrumented tests
UI tests

  • Tests written, or not not needed

@tobiasKaminsky tobiasKaminsky changed the title wip Sort/list change for ReceiveExeternalFilesActivity Jun 2, 2020
@JorisBodin JorisBodin changed the title Sort/list change for ReceiveExeternalFilesActivity Sort/list change for ReceiveExternalFilesActivity.java Jun 2, 2020
AndyScherzinger
AndyScherzinger requested changes Jun 3, 2020
View reviewed changes
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the sorting change gets triggered the button text doesn't change. So the button text needs to be changed/refreshed too.

@tobiasKaminsky
Copy link
Member Author

While the sorting change gets triggered the button text doesn't change. So the button text needs to be changed/refreshed too.

Done

@nextcloud-android-bot
Copy link
Collaborator

master-IT test failed, but no output was generated. Maybe a preliminary stage failed.

@nextcloud-android-bot
Copy link
Collaborator

IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/14331-master-IT

@nextcloud-android-bot
Copy link
Collaborator

stable-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/14331-stable-Screenshot

@nextcloud-android-bot
Copy link
Collaborator

master-IT test failed, but no output was generated. Maybe a preliminary stage failed.

@nextcloud-android-bot
Copy link
Collaborator

IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/14333-master-IT

@nextcloud-android-bot
Copy link
Collaborator

stable-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/14333-stable-Screenshot

@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.13.0 milestone Jun 4, 2020
@tobiasKaminsky
ReceiveExternalFiles to new layout
8a09c3f 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: Joris Bodin <joris.bodin@infomaniak.com>
@JorisBodin JorisBodin self-requested a review June 4, 2020 15:32
@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14346.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

Codacy

390

Lint

TypemasterPR
Warnings9595
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings27
Correctness Warnings64
Internationalization Warnings9
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings75
Security Warnings44
Dodgy code Warnings139
Total371

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings27
Correctness Warnings64
Internationalization Warnings9
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings75
Security Warnings44
Dodgy code Warnings139
Total371

@nextcloud-android-bot
Copy link
Collaborator

stable-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/14346-stable-Screenshot

@AndyScherzinger AndyScherzinger merged commit 27214ae into master Jun 4, 2020
@delete-merged-branch delete-merged-branch bot deleted the receiveExternalChange branch June 4, 2020 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@JorisBodin JorisBodin JorisBodin approved these changes

Assignees
No one assigned
Labels
4. to release
Projects
None yet
Milestone
Nextcloud App 3.13.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tobiasKaminsky @nextcloud-android-bot @AndyScherzinger @JorisBodin