Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some tool hints for easier development #6226

Merged
merged 2 commits into from Jun 6, 2020
Merged

Conversation

stefan-niedermann
Copy link
Member

No code changes, only tool hints for easier and nicer development.

For example send_button.xml

Before:

grafik

After:

grafik

@AndyScherzinger
Copy link
Member

Just a minor comment regarding a missing linebreak due to reformatting 👍

@AndyScherzinger
Copy link
Member

You missed the DCO signing 😉

Signed-off-by: Stefan Niedermann <info@niedermann.it>
Signed-off-by: Stefan Niedermann <info@niedermann.it>
@nextcloud-android-bot
Copy link
Collaborator

@nextcloud-android-bot
Copy link
Collaborator

@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14386.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

@nextcloud-android-bot
Copy link
Collaborator

@nextcloud-android-bot
Copy link
Collaborator

Codacy

394

Lint

TypemasterPR
Warnings9595
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings27
Correctness Warnings64
Internationalization Warnings9
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings75
Security Warnings44
Dodgy code Warnings141
Total373

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings27
Correctness Warnings64
Internationalization Warnings9
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings75
Security Warnings44
Dodgy code Warnings141
Total373

SpotBugs increased!

@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.13.0 milestone Jun 6, 2020
@AndyScherzinger AndyScherzinger merged commit ec5dcef into master Jun 6, 2020
@delete-merged-branch delete-merged-branch bot deleted the tool-hints branch June 6, 2020 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants