Add scan doc upload : take a picture, auto crop image, invert color, transform to pdf #6661

thelittlefireman · 2020-08-06T19:35:07Z

Resolves #2436
Resolves #4435

Testing

Writing tests is very important. Please try to write some tests for your PR.
If you need help, please do not hesitate to ask in this PR for help.

unit tests
instrumented tests
UI tests

Tests written, or not not needed

src/main/java/com/owncloud/android/ui/activity/ScanDocActivity.java

src/main/java/com/owncloud/android/ui/helpers/FileOperationsHelper.java

src/main/java/com/owncloud/android/ui/activity/ScanDocActivity.java

src/main/java/com/owncloud/android/ui/fragment/ScanDocumentFragment.java

+public class ScanDocumentFragment extends Fragment {
+    private static Bitmap editedImageTmp;
+    private final Bitmap editedImage;
+    private boolean isInverted;


src/main/java/com/owncloud/android/ui/activity/ScanDocActivity.java

src/main/java/com/owncloud/android/ui/adapter/ScanDocumentAdapter.java

thelittlefireman · 2020-11-02T14:47:22Z

@AndyScherzinger @tobiasKaminsky
Ready for a peer review :)

nextcloud-android-bot · 2021-02-09T23:13:42Z

stable-IT test failed, but no output was generated. Maybe a preliminary stage failed.

nextcloud-android-bot · 2021-02-09T23:13:57Z

stable-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/569-IT-stable-23-13

nextcloud-android-bot · 2021-02-09T23:16:04Z

Codacy

Lint

Type	master	PR
Warnings	243	243
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	27
Correctness Warnings	53
Internationalization Warnings	9
Multithreaded correctness Warnings	9
Performance Warnings	73
Security Warnings	41
Dodgy code Warnings	98
Total	310

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	27
Correctness Warnings	52
Internationalization Warnings	9
Multithreaded correctness Warnings	9
Performance Warnings	73
Security Warnings	41
Dodgy code Warnings	99
Total	310

SpotBugs increased!

tobiasKaminsky · 2021-02-10T07:15:25Z

@thelittlefireman Thanks for your amazing job!
I tested it and roughly looked at the code, great job!

The only thing I see that we have now ~76Mb more dependencies:

I tried to exclude at least libs for mips and mips64, but it does not work.
I would really like to "only" support this on arm and x86, so that we at least shrink it a bit…

thelittlefireman · 2021-02-10T10:29:35Z

@thelittlefireman Thanks for your amazing job!
I tested it and roughly looked at the code, great job!

The only thing I see that we have now ~76Mb more dependencies:

I tried to exclude at least libs for mips and mips64, but it does not work.
I would really like to "only" support this on arm and x86, so that we at least shrink it a bit…

Thanks you and @AndyScherzinger your help too 😊

I Will have a look if you want. Do you try the split function in gradle to limit arch?

thelittlefireman · 2021-02-10T11:38:42Z

I try to set ndk{ abifilter } i will let you know.
Moreover, we currently use OpenCv Android version 3.4.X for compatibility reason with AndroidDocumentScanner. But
OpenCv 3.4.X size is about 76~86Mb and 4.3.X ~52Mb
https://mvnrepository.com/artifact/com.quickbirdstudios/opencv/4.3.0

I've open an issue , keep an eye on it : mayuce/AndroidDocumentScanner#30

thelittlefireman · 2021-02-10T12:03:09Z

Moreover, (again), thanks to the fact that now nextcloud min api version is 21. Maybe we could migrate to an updated fork of thoses libraries :
https://github.com/meganz/AndroidDocumentScanner
New updates and OpenCV 4.4.0 by default

thelittlefireman · 2021-02-10T13:33:27Z

Moreover, (again), thanks to the fact that now nextcloud min api version is 21. Maybe we could migrate to an updated fork of thoses libraries :
https://github.com/meganz/AndroidDocumentScanner
New updates and OpenCV 4.4.0 by default

I try to change to this new lib but it's in kotlin and so i've got so many errors, maybe we could stay with the original lib for now.

Signed-off-by: thelittlefireman <thelittlefireman@users.noreply.github.com>

nextcloud-android-bot · 2021-02-10T14:23:06Z

stable-IT test failed, but no output was generated. Maybe a preliminary stage failed.

nextcloud-android-bot · 2021-02-10T14:23:14Z

stable-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/578-IT-stable-14-23

nextcloud-android-bot · 2021-02-10T14:40:13Z

Codacy

Lint

Type	master	PR
Warnings	243	243
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	27
Correctness Warnings	53
Internationalization Warnings	9
Multithreaded correctness Warnings	9
Performance Warnings	73
Security Warnings	41
Dodgy code Warnings	98
Total	310

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	27
Correctness Warnings	52
Internationalization Warnings	9
Multithreaded correctness Warnings	9
Performance Warnings	73
Security Warnings	41
Dodgy code Warnings	99
Total	310

SpotBugs increased!

nextcloud-android-bot · 2021-02-23T23:28:50Z

Codacy

Lint

Type	master	PR
Warnings	232	232
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	27
Correctness Warnings	53
Internationalization Warnings	9
Multithreaded correctness Warnings	9
Performance Warnings	73
Security Warnings	40
Dodgy code Warnings	98
Total	309

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	27
Correctness Warnings	52
Internationalization Warnings	9
Multithreaded correctness Warnings	9
Performance Warnings	73
Security Warnings	40
Dodgy code Warnings	99
Total	309

nextcloud-android-bot · 2021-02-23T23:33:26Z

stable-IT test failed, but no output was generated. Maybe a preliminary stage failed.

nextcloud-android-bot · 2021-02-23T23:33:46Z

master-IT test failed, but no output was generated. Maybe a preliminary stage failed.

nextcloud-android-bot · 2021-02-23T23:34:30Z

stable-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/795-IT-stable-23-33

nextcloud-android-bot · 2021-02-23T23:34:48Z

master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/795-IT-master-23-33

thelittlefireman · 2021-03-03T13:33:04Z

Any help needed for the merge ?

AndyScherzinger · 2021-03-03T15:53:47Z

Any help needed for the merge ?

Nothin I asm aware of, there are some (new) conflicts to be resolved with master but other than that we'd have to wait for @tobiasKaminsky's feedback about how to deal with the increased size :/

tobiasKaminsky · 2021-03-17T10:01:05Z

I am really concerned about the file size.
I am not sure if it is a problem at all, or not.
But once this feature is in, on all platform, we cannot get back that easily…

Signed-off-by: thelittlefireman <thelittlefireman@users.noreply.github.com> # Conflicts: # .github/dependabot.yml # .github/workflows/autoApproveDependabot.yml # .github/workflows/detekt.yml # .github/workflows/gPlayFlavor.yml # .github/workflows/genericFlavor.yml # .github/workflows/ktlint.yml # .github/workflows/qa.yml # .gitignore # CHANGELOG.md # build.gradle # gradle.properties # gradle/wrapper/gradle-wrapper.properties # screenshots/gplay/debug/com.nextcloud.client.ActivitiesActivityIT_openDrawer.png # screenshots/gplay/debug/com.nextcloud.client.ActivitiesActivityIT_openDrawer_dark_blue.png # screenshots/gplay/debug/com.nextcloud.client.ActivitiesActivityIT_openDrawer_dark_white.png # screenshots/gplay/debug/com.nextcloud.client.ActivitiesActivityIT_openDrawer_light_white.png # screenshots/gplay/debug/com.nextcloud.client.FileDisplayActivityScreenshotIT_drawer.png # screenshots/gplay/debug/com.nextcloud.client.FileDisplayActivityScreenshotIT_drawer_dark_blue.png # screenshots/gplay/debug/com.nextcloud.client.FileDisplayActivityScreenshotIT_drawer_light_white.png # screenshots/gplay/debug/com.nextcloud.client.SettingsActivityIT_showMnemonic_Error.png # screenshots/gplay/debug/com.nextcloud.client.SettingsActivityIT_showMnemonic_Error_dark_blue.png # screenshots/gplay/debug/com.nextcloud.client.SettingsActivityIT_showMnemonic_Error_dark_white.png # screenshots/gplay/debug/com.nextcloud.client.SettingsActivityIT_showMnemonic_Error_light_white.png # screenshots/gplay/debug/com.nextcloud.client.UploadListActivityActivityIT_openDrawer.png # screenshots/gplay/debug/com.nextcloud.client.UploadListActivityActivityIT_openDrawer_dark_blue.png # screenshots/gplay/debug/com.nextcloud.client.UploadListActivityActivityIT_openDrawer_light_white.png # screenshots/gplay/debug/com.owncloud.android.ui.activity.ConflictsResolveActivityIT_keepBoth.png # screenshots/gplay/debug/com.owncloud.android.ui.activity.ConflictsResolveActivityIT_keepBoth_dark_blue.png # screenshots/gplay/debug/com.owncloud.android.ui.activity.ConflictsResolveActivityIT_keepBoth_dark_white.png # screenshots/gplay/debug/com.owncloud.android.ui.activity.ConflictsResolveActivityIT_keepBoth_light_white.png # screenshots/gplay/debug/com.owncloud.android.ui.activity.ConflictsResolveActivityIT_keepExisting.png # screenshots/gplay/debug/com.owncloud.android.ui.activity.ConflictsResolveActivityIT_keepExisting_dark_blue.png # screenshots/gplay/debug/com.owncloud.android.ui.activity.ConflictsResolveActivityIT_keepExisting_dark_white.png # screenshots/gplay/debug/com.owncloud.android.ui.activity.ConflictsResolveActivityIT_keepExisting_light_white.png # screenshots/gplay/debug/com.owncloud.android.ui.activity.ConflictsResolveActivityIT_keepNew.png # screenshots/gplay/debug/com.owncloud.android.ui.activity.ConflictsResolveActivityIT_keepNew_dark_blue.png # screenshots/gplay/debug/com.owncloud.android.ui.activity.ConflictsResolveActivityIT_keepNew_dark_white.png # screenshots/gplay/debug/com.owncloud.android.ui.activity.ConflictsResolveActivityIT_keepNew_light_white.png # screenshots/gplay/debug/com.owncloud.android.ui.activity.ConflictsResolveActivityIT_screenshotTextFiles.png # screenshots/gplay/debug/com.owncloud.android.ui.activity.ConflictsResolveActivityIT_screenshotTextFiles_dark_blue.png # screenshots/gplay/debug/com.owncloud.android.ui.activity.ConflictsResolveActivityIT_screenshotTextFiles_dark_white.png # screenshots/gplay/debug/com.owncloud.android.ui.activity.ConflictsResolveActivityIT_screenshotTextFiles_light_white.png # screenshots/gplay/debug/com.owncloud.android.ui.activity.NotificationsActivityIT_empty_dark_blue.png # screenshots/gplay/debug/com.owncloud.android.ui.activity.NotificationsActivityIT_empty_dark_white.png # screenshots/gplay/debug/com.owncloud.android.ui.activity.NotificationsActivityIT_empty_light_white.png # screenshots/gplay/debug/com.owncloud.android.ui.activity.NotificationsActivityIT_error_dark_blue.png # screenshots/gplay/debug/com.owncloud.android.ui.activity.NotificationsActivityIT_error_dark_white.png # screenshots/gplay/debug/com.owncloud.android.ui.activity.NotificationsActivityIT_error_light_white.png # screenshots/gplay/debug/com.owncloud.android.ui.activity.NotificationsActivityIT_loading.png # screenshots/gplay/debug/com.owncloud.android.ui.activity.NotificationsActivityIT_loading_dark_blue.png # screenshots/gplay/debug/com.owncloud.android.ui.activity.NotificationsActivityIT_loading_dark_white.png # screenshots/gplay/debug/com.owncloud.android.ui.activity.NotificationsActivityIT_loading_light_white.png # screenshots/gplay/debug/com.owncloud.android.ui.activity.NotificationsActivityIT_showNotifications_dark_blue.png # screenshots/gplay/debug/com.owncloud.android.ui.activity.NotificationsActivityIT_showNotifications_dark_white.png # screenshots/gplay/debug/com.owncloud.android.ui.activity.NotificationsActivityIT_showNotifications_light_white.png # screenshots/gplay/debug/com.owncloud.android.ui.activity.PassCodeActivityIT_check.png # screenshots/gplay/debug/com.owncloud.android.ui.activity.PassCodeActivityIT_check_dark_blue.png # screenshots/gplay/debug/com.owncloud.android.ui.activity.PassCodeActivityIT_check_dark_white.png # screenshots/gplay/debug/com.owncloud.android.ui.activity.PassCodeActivityIT_check_light_white.png # screenshots/gplay/debug/com.owncloud.android.ui.activity.PassCodeActivityIT_delete.png # screenshots/gplay/debug/com.owncloud.android.ui.activity.PassCodeActivityIT_delete_dark_blue.png # screenshots/gplay/debug/com.owncloud.android.ui.activity.PassCodeActivityIT_delete_dark_white.png # screenshots/gplay/debug/com.owncloud.android.ui.activity.PassCodeActivityIT_delete_light_white.png # screenshots/gplay/debug/com.owncloud.android.ui.activity.PassCodeActivityIT_request.png # screenshots/gplay/debug/com.owncloud.android.ui.activity.PassCodeActivityIT_request_dark_blue.png # screenshots/gplay/debug/com.owncloud.android.ui.activity.PassCodeActivityIT_request_dark_white.png # screenshots/gplay/debug/com.owncloud.android.ui.activity.PassCodeActivityIT_request_light_white.png # screenshots/gplay/debug/com.owncloud.android.ui.dialog.DialogFragmentIT_testNewFolderDialog_dark_blue.png # screenshots/gplay/debug/com.owncloud.android.ui.dialog.DialogFragmentIT_testNewFolderDialog_dark_white.png # screenshots/gplay/debug/com.owncloud.android.ui.dialog.DialogFragmentIT_testNewFolderDialog_light_white.png # screenshots/gplay/debug/com.owncloud.android.ui.dialog.DialogFragmentIT_testRenameFileDialog_dark_blue.png # screenshots/gplay/debug/com.owncloud.android.ui.dialog.DialogFragmentIT_testRenameFileDialog_dark_white.png # screenshots/gplay/debug/com.owncloud.android.ui.dialog.DialogFragmentIT_testRenameFileDialog_light_white.png # screenshots/gplay/debug/com.owncloud.android.ui.dialog.SendShareDialogTest_showDialog_dark_white.png # screenshots/gplay/debug/com.owncloud.android.ui.dialog.SendShareDialogTest_showDialog_light_white.png # screenshots/gplay/debug/com.owncloud.android.ui.dialog.SetupEncryptionDialogFragmentIT_error_dark_white.png # screenshots/gplay/debug/com.owncloud.android.ui.dialog.SetupEncryptionDialogFragmentIT_error_light_white.png # screenshots/gplay/debug/com.owncloud.android.ui.dialog.SetupEncryptionDialogFragmentIT_showMnemonic.png # screenshots/gplay/debug/com.owncloud.android.ui.dialog.SetupEncryptionDialogFragmentIT_showMnemonic_dark_blue.png # screenshots/gplay/debug/com.owncloud.android.ui.dialog.SetupEncryptionDialogFragmentIT_showMnemonic_dark_white.png # screenshots/gplay/debug/com.owncloud.android.ui.dialog.SetupEncryptionDialogFragmentIT_showMnemonic_light_white.png # screenshots/gplay/debug/com.owncloud.android.ui.fragment.FileDetailFragmentStaticServerIT_showDetailsActivities.png # screenshots/gplay/debug/com.owncloud.android.ui.fragment.FileDetailFragmentStaticServerIT_showDetailsActivitiesError.png # screenshots/gplay/debug/com.owncloud.android.ui.fragment.FileDetailFragmentStaticServerIT_showDetailsActivitiesError_dark_blue.png # screenshots/gplay/debug/com.owncloud.android.ui.fragment.FileDetailFragmentStaticServerIT_showDetailsActivitiesError_dark_white.png # screenshots/gplay/debug/com.owncloud.android.ui.fragment.FileDetailFragmentStaticServerIT_showDetailsActivitiesError_light_white.png # screenshots/gplay/debug/com.owncloud.android.ui.fragment.FileDetailFragmentStaticServerIT_showDetailsActivitiesNone.png # screenshots/gplay/debug/com.owncloud.android.ui.fragment.FileDetailFragmentStaticServerIT_showDetailsActivitiesNone_dark_blue.png # screenshots/gplay/debug/com.owncloud.android.ui.fragment.FileDetailFragmentStaticServerIT_showDetailsActivitiesNone_dark_white.png # screenshots/gplay/debug/com.owncloud.android.ui.fragment.FileDetailFragmentStaticServerIT_showDetailsActivitiesNone_light_white.png # screenshots/gplay/debug/com.owncloud.android.ui.fragment.FileDetailFragmentStaticServerIT_showDetailsActivities_dark_blue.png # screenshots/gplay/debug/com.owncloud.android.ui.fragment.FileDetailFragmentStaticServerIT_showDetailsActivities_dark_white.png # screenshots/gplay/debug/com.owncloud.android.ui.fragment.FileDetailFragmentStaticServerIT_showDetailsActivities_light_white.png # screenshots/gplay/debug/com.owncloud.android.ui.fragment.FileDetailFragmentStaticServerIT_showDetailsSharing.png # screenshots/gplay/debug/com.owncloud.android.ui.fragment.FileDetailFragmentStaticServerIT_showDetailsSharing_dark_blue.png # screenshots/gplay/debug/com.owncloud.android.ui.fragment.FileDetailFragmentStaticServerIT_showDetailsSharing_dark_white.png # screenshots/gplay/debug/com.owncloud.android.ui.fragment.FileDetailFragmentStaticServerIT_showDetailsSharing_light_white.png # screenshots/gplay/debug/com.owncloud.android.ui.fragment.FileDetailFragmentStaticServerIT_showFileDetailActivitiesFragment.png # screenshots/gplay/debug/com.owncloud.android.ui.fragment.FileDetailFragmentStaticServerIT_showFileDetailActivitiesFragment_dark_blue.png # screenshots/gplay/debug/com.owncloud.android.ui.fragment.FileDetailFragmentStaticServerIT_showFileDetailActivitiesFragment_dark_white.png # screenshots/gplay/debug/com.owncloud.android.ui.fragment.FileDetailFragmentStaticServerIT_showFileDetailActivitiesFragment_light_white.png # screenshots/gplay/debug/com.owncloud.android.ui.fragment.FileDetailFragmentStaticServerIT_showFileDetailSharingFragment.png # screenshots/gplay/debug/com.owncloud.android.ui.fragment.FileDetailFragmentStaticServerIT_showFileDetailSharingFragment_dark_blue.png # screenshots/gplay/debug/com.owncloud.android.ui.fragment.FileDetailFragmentStaticServerIT_showFileDetailSharingFragment_dark_white.png # screenshots/gplay/debug/com.owncloud.android.ui.fragment.FileDetailFragmentStaticServerIT_showFileDetailSharingFragment_light_white.png # screenshots/gplay/debug/com.owncloud.android.ui.fragment.FileDetailSharingFragmentIT_listSharesFileAllShareTypes.png # screenshots/gplay/debug/com.owncloud.android.ui.fragment.FileDetailSharingFragmentIT_listSharesFileAllShareTypes_dark_blue.png # screenshots/gplay/debug/com.owncloud.android.ui.fragment.FileDetailSharingFragmentIT_listSharesFileAllShareTypes_dark_white.png # screenshots/gplay/debug/com.owncloud.android.ui.fragment.FileDetailSharingFragmentIT_listSharesFileAllShareTypes_light_white.png # screenshots/gplay/debug/com.owncloud.android.ui.fragment.FileDetailSharingFragmentIT_listSharesFileNone.png # screenshots/gplay/debug/com.owncloud.android.ui.fragment.FileDetailSharingFragmentIT_listSharesFileNone_dark_blue.png # screenshots/gplay/debug/com.owncloud.android.ui.fragment.FileDetailSharingFragmentIT_listSharesFileNone_dark_white.png # screenshots/gplay/debug/com.owncloud.android.ui.fragment.FileDetailSharingFragmentIT_listSharesFileNone_light_white.png # screenshots/gplay/debug/com.owncloud.android.ui.fragment.FileDetailSharingFragmentIT_listSharesFileResharingNotAllowed.png # screenshots/gplay/debug/com.owncloud.android.ui.fragment.FileDetailSharingFragmentIT_listSharesFileResharingNotAllowed_dark_blue.png # screenshots/gplay/debug/com.owncloud.android.ui.fragment.FileDetailSharingFragmentIT_listSharesFileResharingNotAllowed_dark_white.png # screenshots/gplay/debug/com.owncloud.android.ui.fragment.FileDetailSharingFragmentIT_listSharesFileResharingNotAllowed_light_white.png # screenshots/gplay/debug/com.owncloud.android.ui.fragment.OCFileListFragmentStaticServerIT_showSharedFiles_dark_white.png # screenshots/gplay/debug/com.owncloud.android.ui.fragment.OCFileListFragmentStaticServerIT_showSharedFiles_light_white.png # scripts/analysis/findbugs-results.txt # scripts/analysis/lint-results.txt # scripts/deleteOldComments.sh # src/androidTest/java/com/owncloud/android/providers/DocumentsStorageProviderIT.kt # src/androidTest/java/com/owncloud/android/ui/activity/PassCodeActivityIT.kt # src/androidTest/java/com/owncloud/android/ui/dialog/DialogFragmentIT.java # src/androidTest/java/com/owncloud/android/ui/dialog/SendShareDialogTest.kt # src/androidTest/java/com/owncloud/android/ui/fragment/FileDetailFragmentStaticServerIT.kt # src/debug/java/com/nextcloud/client/TestActivity.kt # src/main/java/com/nextcloud/client/jobs/MediaFoldersDetectionWork.kt # src/main/java/com/nextcloud/client/media/PlayerService.kt # src/main/java/com/nextcloud/client/network/ConnectivityServiceImpl.java # src/main/java/com/nextcloud/ui/ChooseAccountDialogFragment.kt # src/main/java/com/nextcloud/ui/SetStatusDialogFragment.kt # src/main/java/com/owncloud/android/authentication/AuthenticatorActivity.java # src/main/java/com/owncloud/android/authentication/DeepLinkLoginActivity.java # src/main/java/com/owncloud/android/db/ProviderMeta.java # src/main/java/com/owncloud/android/files/services/FileDownloader.java # src/main/java/com/owncloud/android/files/services/FileUploader.java # src/main/java/com/owncloud/android/operations/CheckCurrentCredentialsOperation.java # src/main/java/com/owncloud/android/operations/RefreshFolderOperation.java # src/main/java/com/owncloud/android/providers/DocumentsStorageProvider.java # src/main/java/com/owncloud/android/providers/FileContentProvider.java # src/main/java/com/owncloud/android/providers/UsersAndGroupsSearchProvider.java # src/main/java/com/owncloud/android/ui/TextDrawable.java # src/main/java/com/owncloud/android/ui/activities/ActivitiesActivity.java # src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.java # src/main/java/com/owncloud/android/ui/activity/NotificationsActivity.java # src/main/java/com/owncloud/android/ui/activity/PassCodeActivity.java # src/main/java/com/owncloud/android/ui/activity/ReceiveExternalFilesActivity.java # src/main/java/com/owncloud/android/ui/activity/SyncedFoldersActivity.java # src/main/java/com/owncloud/android/ui/activity/UserInfoActivity.java # src/main/java/com/owncloud/android/ui/adapter/LinkShareViewHolder.java # src/main/java/com/owncloud/android/ui/adapter/OCFileListAdapter.java # src/main/java/com/owncloud/android/ui/adapter/ShareViewHolder.java # src/main/java/com/owncloud/android/ui/asynctasks/CopyAndUploadContentUrisTask.java # src/main/java/com/owncloud/android/ui/asynctasks/RetrieveStatusAsyncTask.java # src/main/java/com/owncloud/android/ui/dialog/ChooseRichDocumentsTemplateDialogFragment.java # src/main/java/com/owncloud/android/ui/dialog/ConflictsResolveDialog.java # src/main/java/com/owncloud/android/ui/dialog/SetupEncryptionDialogFragment.java # src/main/java/com/owncloud/android/ui/dialog/SharePasswordDialogFragment.java # src/main/java/com/owncloud/android/ui/fragment/FileDetailActivitiesFragment.java # src/main/java/com/owncloud/android/ui/fragment/FileDetailFragment.java # src/main/java/com/owncloud/android/ui/fragment/FileDetailSharingFragment.java # src/main/java/com/owncloud/android/ui/fragment/OCFileListBottomSheetDialog.java # src/main/java/com/owncloud/android/ui/fragment/OCFileListFragment.java # src/main/java/com/owncloud/android/ui/fragment/contactsbackup/ContactListFragment.java # src/main/java/com/owncloud/android/ui/fragment/contactsbackup/ContactsBackupFragment.java # src/main/java/com/owncloud/android/ui/helpers/FileOperationsHelper.java # src/main/java/com/owncloud/android/ui/helpers/UriUploader.java # src/main/java/com/owncloud/android/ui/preview/PreviewTextStringFragment.java # src/main/java/com/owncloud/android/utils/BitmapUtils.java # src/main/java/com/owncloud/android/utils/ThemeUtils.java # src/main/res/drawable/nextcloud_logo.xml # src/main/res/layout-land/account_setup.xml # src/main/res/layout/account_setup.xml # src/main/res/layout/activity_list_item.xml # src/main/res/layout/dialog_set_status.xml # src/main/res/layout/drawer_header.xml # src/main/res/layout/file_details_activities_fragment.xml # src/main/res/layout/file_details_fragment.xml # src/main/res/layout/file_details_share_group.xml # src/main/res/layout/file_details_share_internal_share_link.xml # src/main/res/layout/file_details_share_link_share_item.xml # src/main/res/layout/file_details_share_share_item.xml # src/main/res/layout/file_details_sharing_fragment.xml # src/main/res/layout/passcodelock.xml # src/main/res/layout/password_dialog.xml # src/main/res/values-b+en+001/strings.xml # src/main/res/values-cs-rCZ/strings.xml # src/main/res/values-da/strings.xml # src/main/res/values-de/strings.xml # src/main/res/values-es-rAR/strings.xml # src/main/res/values-es/strings.xml # src/main/res/values-eu/strings.xml # src/main/res/values-fi-rFI/strings.xml # src/main/res/values-gl/strings.xml # src/main/res/values-it/strings.xml # src/main/res/values-lt-rLT/strings.xml # src/main/res/values-nl/strings.xml # src/main/res/values-pl/strings.xml # src/main/res/values-pt-rBR/strings.xml # src/main/res/values-ru/strings.xml # src/main/res/values-sl/strings.xml # src/main/res/values-tk/strings.xml # src/main/res/values-tr/strings.xml # src/main/res/values-vi/strings.xml # src/main/res/values-zh-rCN/strings.xml # src/main/res/values-zh-rHK/strings.xml # src/main/res/values-zh-rTW/strings.xml # src/main/res/values/dims.xml # src/main/res/values/strings.xml # src/main/res/values/styles.xml # src/test/java/com/nextcloud/client/network/ConnectivityServiceTest.kt

rthery · 2021-03-28T14:08:34Z

(Hello, sneaking in since I'm very interested by this feature)

Regarding the size issue, the best solution is to build opencv with only the required modules by the app, and avoid bringing the whole library which is indeed enormous (for mobile). Of course splitting the APK per architecture would be nice as well if it's not done yet.

If you need help, let me know, I'll try to find some time for it.

thelittlefireman · 2021-03-28T16:48:49Z

@AndyScherzinger @tobiasKaminsky
ok guys, i've made a completely new PR. I've switch to https://github.com/meganz/AndroidDocumentScanner. The apk size is now about 36 Mb, is it better ?
I used the default activity of this library. We are loosing a feature : invert color.

#8217

and sorry for the mess rebase in this current PR x)

tobiasKaminsky · 2021-04-27T06:09:33Z

Regarding size: QuickBirdEng/opencv-android#42 (comment)

thelittlefireman · 2021-04-27T14:03:28Z

Regarding size: quickbirdstudios/opencv-android#42 (comment)

Already done; see my previous message :) ==> size was about 86Mb

I try to set ndk{ abifilter } i will let you know.
Moreover, we currently use OpenCv Android version 3.4.X for compatibility reason with AndroidDocumentScanner. But
OpenCv 3.4.X size is about 76~86Mb and 4.3.X ~52Mb
https://mvnrepository.com/artifact/com.quickbirdstudios/opencv/4.3.0

I've open an issue , keep an eye on it : mayuce/AndroidDocumentScanner#30

AlvaroBrey · 2022-03-21T09:03:17Z

Superseded by #9717

This comment has been minimized.

Sign in to view

AndyScherzinger added the 2. developing label Aug 6, 2020

This comment has been minimized.

Sign in to view

AndyScherzinger force-pushed the add_scan_doc branch from f26727a to 8317b1b Compare August 18, 2020 14:49

This comment has been minimized.

Sign in to view

thelittlefireman force-pushed the add_scan_doc branch from 8317b1b to 810922f Compare October 1, 2020 22:43

This comment has been minimized.

Sign in to view

thelittlefireman force-pushed the add_scan_doc branch from a1ee725 to 6e654ae Compare October 1, 2020 23:32

thelittlefireman force-pushed the add_scan_doc branch from 6e654ae to fb40c11 Compare October 28, 2020 15:29