Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add skip option in case of name collision #7011

Merged
merged 2 commits into from Oct 2, 2020
Merged

add skip option in case of name collision #7011

merged 2 commits into from Oct 2, 2020

Conversation

dassio
Copy link
Contributor

@dassio dassio commented Sep 25, 2020

Signed-off-by: dassio dassio@icloud.com

Testing

test has be already implemented at : FileUploaderIT.kt

  • Tests written, or not not needed

Signed-off-by: dassio <dassio@icloud.com>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Copy link
Collaborator

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
           

See the complete overview on Codacy

@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16029.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

@nextcloud-android-bot
Copy link
Collaborator

Codacy

Lint

TypemasterPR
Warnings7777
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings27
Correctness Warnings53
Internationalization Warnings9
Multithreaded correctness Warnings9
Performance Warnings72
Security Warnings44
Dodgy code Warnings105
Total319

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings27
Correctness Warnings53
Internationalization Warnings9
Multithreaded correctness Warnings9
Performance Warnings72
Security Warnings44
Dodgy code Warnings105
Total319

@AndyScherzinger AndyScherzinger merged commit 61aaba5 into nextcloud:master Oct 2, 2020
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.14.0 milestone Oct 2, 2020
thelittlefireman pushed a commit to thelittlefireman/android that referenced this pull request Mar 19, 2021
add skip option in case of name collision
Signed-off-by: thelittlefireman <thelittlefireman@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants