Fix Push notifications #7619
Merged
Fix Push notifications #7619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyScherzinger
approved these changes
Dec 7, 2020
|
/backport to stable-3.14 |
use NC specific user agent for Push Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
AndyScherzinger
force-pushed
the
proxyWithUA
branch
from
0734814
to
fd30675
Compare
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/7619.apk |
|
White-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/7619-Screenshot-White-Light-09-08 |
thelittlefireman
pushed a commit
to thelittlefireman/android
that referenced
this pull request
Mar 19, 2021
Fix Push notifications Signed-off-by: thelittlefireman <thelittlefireman@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs: nextcloud/android-library#551
Fix #1964
Downgrade firebase-messaging
use NC specific user agent for Push
Signed-off-by: tobiasKaminsky tobias@kaminsky.me
Testing
Writing tests is very important. Please try to write some tests for your PR.
If you need help, please do not hesitate to ask in this PR for help.
unit tests
instrumented tests
UI tests
write test case (end to end!!)-> Postponed: Create End-2-End Push Notification Test #7716