[stable-3.19] Fix crashes and double loading in GalleryFragment when changing dark theme #9767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot-nextcloud[bot]](https://avatars.githubusercontent.com/in/21012?s=60&v=4){kind=small}
getStorageManager() is not available in onCreate Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
…imations This fixes bugs with double-loading and weird animations Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
backportbot-nextcloud
bot
requested review from
AlvaroBrey and
tobiasKaminsky
AlvaroBrey
approved these changes
Jan 27, 2022
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/9767.apk |
Lint
SpotBugs (new)
SpotBugs (stable-3.19)
|
|
blue-Light-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/9767-Screenshot-blue-Light-12-13 |
Codecov Report
@@ Coverage Diff @@
## stable-3.19 #9767 +/- ##
==================================================
+ Coverage 2.71% 31.60% +28.89%
==================================================
Files 505 505
Lines 38594 38597 +3
Branches 5379 5380 +1
==================================================
+ Hits 1048 12200 +11152
+ Misses 37496 24563 -12933
- Partials 50 1834 +1784
|
tobiasKaminsky
approved these changes
Jan 27, 2022
|
blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/9767-Screenshot-blue-Light-14-30 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #9743