Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instant upload in the context of multi account support #98

Closed
wants to merge 15 commits into from

Conversation

AndyScherzinger
Copy link
Member

Work in progress PR for #25

*/
private void saveInstantUploadPathOnPreferences() {
SharedPreferences appPrefs =
PreferenceManager.getDefaultSharedPreferences(getApplicationContext());
SharedPreferences.Editor editor = appPrefs.edit();
editor.putString("instant_upload_path", mUploadPath);
editor.putString("instant_upload_path_account", mUploadPathAccount);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

putString returns Editor so you can chain but thats nothing big

@AndyScherzinger AndyScherzinger force-pushed the instant_upload_multi_account branch 3 times, most recently from f52ba76 to d329bbb Compare July 21, 2016 15:05
@AndyScherzinger AndyScherzinger force-pushed the instant_upload_multi_account branch 2 times, most recently from aeb9ea9 to 6b36468 Compare August 2, 2016 17:42
@AndyScherzinger AndyScherzinger force-pushed the instant_upload_multi_account branch 3 times, most recently from 590b070 to 015803f Compare August 8, 2016 21:58
@AndyScherzinger AndyScherzinger force-pushed the instant_upload_multi_account branch 2 times, most recently from b138431 to 07bf5ac Compare August 18, 2016 14:20
@AndyScherzinger AndyScherzinger force-pushed the instant_upload_multi_account branch 3 times, most recently from 32cbc83 to d7cf257 Compare September 8, 2016 08:56
@AndyScherzinger AndyScherzinger force-pushed the instant_upload_multi_account branch 2 times, most recently from c3b39ce to 05275b7 Compare September 15, 2016 09:34
@AndyScherzinger AndyScherzinger force-pushed the instant_upload_multi_account branch 2 times, most recently from b60ecfd to f35d560 Compare March 3, 2017 21:56
@tobiasKaminsky
Copy link
Member

Is this something still up to date as of the big rewrite of @mario?

@mario
Copy link
Contributor

mario commented Mar 5, 2017 via email

@mario
Copy link
Contributor

mario commented Mar 5, 2017 via email

@AndyScherzinger
Copy link
Member Author

This one is obsolete as soon as auto upload is active for all Android versions!
Thanks to @mario's efforts with auto upload 🚀

@tobiasKaminsky
Copy link
Member

This one is obsolete as soon as auto upload is active for all Android versions!

I thought that auto Upload is only possible for >= 5 as of JobScheduler?

@AndyScherzinger
Copy link
Member Author

AFAIK it'll work on earlier versions too since @mario integrated Evernote job library which will fallback to an AlarmManager implementation to mimic JobScheduler so that should then be solved too. Right @mario?

@mario
Copy link
Contributor

mario commented Mar 5, 2017 via email

@tobiasKaminsky
Copy link
Member

Thanks for explanation --> closing

@tobiasKaminsky tobiasKaminsky deleted the instant_upload_multi_account branch June 23, 2017 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants