-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instant upload in the context of multi account support #98
Conversation
*/ | ||
private void saveInstantUploadPathOnPreferences() { | ||
SharedPreferences appPrefs = | ||
PreferenceManager.getDefaultSharedPreferences(getApplicationContext()); | ||
SharedPreferences.Editor editor = appPrefs.edit(); | ||
editor.putString("instant_upload_path", mUploadPath); | ||
editor.putString("instant_upload_path_account", mUploadPathAccount); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
putString returns Editor so you can chain but thats nothing big
46df37a
to
a6ef30c
Compare
f52ba76
to
d329bbb
Compare
aeb9ea9
to
6b36468
Compare
590b070
to
015803f
Compare
b138431
to
07bf5ac
Compare
32cbc83
to
d7cf257
Compare
c3b39ce
to
05275b7
Compare
05275b7
to
b711ff9
Compare
b60ecfd
to
f35d560
Compare
46c4dda
to
09c8710
Compare
Is this something still up to date as of the big rewrite of @mario? |
I have to check what is this.
…On Sun, 5 Mar 2017 at 09:55, Tobias Kaminsky ***@***.***> wrote:
Is this something still up to date as of the big rewrite of @mario
<https://github.com/mario>?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#98 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAAWsqLJrFqPLX1AS3iTQdU0rlEs5pD_ks5rinhugaJpZM4JF9dx>
.
|
Looks outdated, can be deleted.
I think we need to respect account disabled for Auto Upload, but dont think
this is something that is respected across the app at all atm, and the rest
of this is useless since instant upload disappears.
…On Sun, 5 Mar 2017 at 09:55, Tobias Kaminsky ***@***.***> wrote:
Is this something still up to date as of the big rewrite of @mario
<https://github.com/mario>?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#98 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAAWsqLJrFqPLX1AS3iTQdU0rlEs5pD_ks5rinhugaJpZM4JF9dx>
.
|
This one is obsolete as soon as auto upload is active for all Android versions! |
I thought that auto Upload is only possible for >= 5 as of JobScheduler? |
It will use GCM network manager on 4 starting Nextcloud 1.5 :)
1.4.2 enables it only for 6 and 7.
…On Sun, 5 Mar 2017 at 12:54, Tobias Kaminsky ***@***.***> wrote:
This one is obsolete as soon as auto upload is active for all Android
versions!
I thought that auto Upload is only possible for >= 5 as of JobScheduler?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#98 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAAWsiTtJ1ysvnzxAg7W2zj9nbCBNl9gks5riqJ9gaJpZM4JF9dx>
.
|
Thanks for explanation --> closing |
Work in progress PR for #25