Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature default NC27 #285

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Feature default NC27 #285

merged 1 commit into from
Jun 26, 2023

Conversation

staticdev
Copy link
Collaborator

@staticdev staticdev commented Jun 19, 2023 •
edited
Loading

Closes #283

@staticdev staticdev mentioned this pull request Jun 22, 2023
Merged
@staticdev staticdev changed the title Feature default NC27 WIP: Feature default NC27 Jun 22, 2023
@staticdev
Feature default NC27
8b210d8 
Signed-off-by: staticdev <staticdev-support@proton.me>
@staticdev
Copy link
Collaborator Author

@wiktor2200 I am having a strange behavior.. locally it is working good the playbook, but on GA not. Could you try to run molecule test locally?

@wiktor2200
Copy link
Collaborator

Hi @staticdev! The same on my side. I confirm that it works locally, but on GA I'm having errors. I've also noticed, that errors also showing up in other steps (such as linter).
First attempt failed: https://github.com/nextcloud/ansible-collection-nextcloud-admin/actions/runs/5363160101/attempts/1
But then after re-play it started working: https://github.com/nextcloud/ansible-collection-nextcloud-admin/actions/runs/5363160101

@staticdev staticdev changed the title WIP: Feature default NC27 Feature default NC27 Jun 25, 2023
@staticdev
Copy link
Collaborator Author

staticdev commented Jun 25, 2023 •
edited
Loading

@wiktor2200 then, I also suggest to merge and watch. Then I will start working now on Debian 12 upgrade ;) Not sure how to open an issue on GA about that.

wiktor2200
wiktor2200 approved these changes Jun 26, 2023
View reviewed changes
Copy link
Collaborator

@wiktor2200 wiktor2200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @staticdev! I totally agree, merging this one will solve at least problems with tests and molecule.
GA related problems may be fixed automatically by GA contributors/maintainers and maybe we will get affected :)

@wiktor2200 wiktor2200 merged commit 2151868 into main Jun 26, 2023
3 of 7 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feature/default-nc27 branch June 26, 2023 16:59
@wiktor2200 wiktor2200 added the enhancement New feature or request label Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiktor2200 wiktor2200 wiktor2200 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update default nc to 27
2 participants
@staticdev @wiktor2200