refactor(scaffolding): Migrate app template to Github template repo (#…

…1368)

* refactor(scaffolding): Migrate app template to Github template repo

Signed-off-by: provokateurin <kate@provokateurin.de>

---------

Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

.github/workflows/analysis-coverage.yml

@@ -35,6 +35,8 @@ jobs:
 
     steps:
       - uses: actions/checkout@v4
+        with:
+          submodules: true
       - name: Install dependencies
         run: sudo apt install gettext netcat-openbsd xvfb redis-server
 

.gitmodules

@@ -0,0 +1,3 @@
+[submodule "nextcloudappstore/scaffolding/app_template"]
+	path = nextcloudappstore/scaffolding/app_template
+	url = https://github.com/nextcloud/app_template.git

nextcloudappstore/core/models.py

@@ -694,8 +694,7 @@ def __str__(self) -> str:
 
 
 class NextcloudReleaseManager(Manager):
-    def get_current(self):
-        return self.get_queryset().filter(is_current=True)[:1]
+    pass
 
 
 class NextcloudRelease(Model):
@@ -736,13 +735,5 @@ class Meta:
         verbose_name_plural = _("Nextcloud releases")
         ordering = ("-version",)
 
-    @staticmethod
-    def get_current_main():
-        current = NextcloudRelease.objects.get_current()
-        if len(current) > 0:
-            return current[0].version.split(".")[0]
-        else:
-            return None
-
     def __str__(self):
         return self.version

nextcloudappstore/core/tests/e2e/test_scaffolding.py

@@ -21,5 +21,5 @@ def test_scaffold(self):
         self.by_id("id_description").send_keys("This app does nothing")
 
         valid_elems = self.by_css("#app-generate-form *:valid", True)
-        self.assertEqual(11, len(valid_elems))
+        self.assertEqual(10, len(valid_elems))
         self.by_id("submit").click()