Skip to content

Commit

Permalink
Merge c9afc98 into 5c2996d
Browse files Browse the repository at this point in the history
  • Loading branch information
tcitworld committed Aug 6, 2018
2 parents 5c2996d + c9afc98 commit 4e6b0bf
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 3 deletions.
6 changes: 5 additions & 1 deletion js/app/service/calendarService.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
*
*/

app.service('CalendarService', function(DavClient, StringUtility, XMLUtility, CalendarFactory, isPublic, constants) {
app.service('CalendarService', function(DavClient, StringUtility, XMLUtility, CalendarFactory, isPublic, constants, TimezoneService) {
'use strict';

const context = {
Expand Down Expand Up @@ -303,6 +303,10 @@ app.service('CalendarService', function(DavClient, StringUtility, XMLUtility, Ca
name: [DavClient.NS_DAV, 'd:displayname'],
value: name
});
dPropChildren.push({
name: [DavClient.NS_IETF, 'c:calendar-timezone'],
value: TimezoneService.getDetected()
});
dPropChildren.push({
name: [DavClient.NS_APPLE, 'a:calendar-color'],
value: color
Expand Down
17 changes: 15 additions & 2 deletions tests/js/unit/services/calendarServiceSpec.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
describe('CalendarService non-public', function () {
'use strict';

let CalendarService, DavClient, StringUtility, XMLUtility, CalendarFactory, WebCal, $q, $rootScope, davService, constants;
let CalendarService, DavClient, StringUtility, XMLUtility, CalendarFactory, WebCal, $q, $rootScope, davService, constants, TimezoneService;
let firstPropFindDeferred, secondPropFindDeferred, thirdPropFindDeferred;
let firstRequestDeferred, secondRequestDeferred, thirdRequestDeferred;
let updateSpy;
Expand Down Expand Up @@ -735,13 +735,17 @@ END:VCALENDAR
OC.requestToken = 'requestToken42';
OC.linkToRemoteBase = jasmine.createSpy();

TimezoneService = {};
TimezoneService.getDetected = jasmine.createSpy();

$provide.value('DavClient', DavClient);
$provide.value('StringUtility', StringUtility);
$provide.value('XMLUtility', XMLUtility);
$provide.value('CalendarFactory', CalendarFactory);
$provide.value('WebCal', WebCal);
$provide.value('isPublic', false);
$provide.value('constants', {});
$provide.value('TimezoneService', TimezoneService);
}));

beforeEach(inject(function (_$q_, _$rootScope_) {
Expand All @@ -757,6 +761,7 @@ END:VCALENDAR
OC.linkToRemoteBase.and.returnValue('remote-dav');
DavClient.buildUrl.and.returnValues('fancy-url-1', 'fancy-url-2', 'fancy-url-3', 'fancy-url-4');
StringUtility.uri.and.returnValues('uri-1', 'uri-2', 'uri-3', 'uri-4');
TimezoneService.getDetected.and.returnValue('Europe/Berlin');

firstPropFindDeferred = $q.defer();
secondPropFindDeferred = $q.defer();
Expand Down Expand Up @@ -1089,6 +1094,9 @@ END:VCALENDAR
},{
name: ['DAV:', 'd:displayname'],
value: 'name-foobar-1337'
},{
name: ['urn:ietf:params:xml:ns:caldav', 'c:calendar-timezone'],
value: 'Europe/Berlin'
},{
name: ['http://apple.com/ns/ical/', 'a:calendar-color'],
value: '#eeeeee'
Expand Down Expand Up @@ -1357,7 +1365,7 @@ END:VCALENDAR
describe('CalendarService - public', function() {
'use strict';

let CalendarService, DavClient, StringUtility, XMLUtility, CalendarFactory, WebCal, $q, $rootScope, davService, constants;
let CalendarService, DavClient, StringUtility, XMLUtility, CalendarFactory, WebCal, $q, $rootScope, davService, constants, TimezoneService;
let firstPropFindDeferred, secondPropFindDeferred, thirdPropFindDeferred;
let firstRequestDeferred, secondRequestDeferred, thirdRequestDeferred;

Expand Down Expand Up @@ -1515,13 +1523,17 @@ describe('CalendarService - public', function() {
OC.requestToken = 'requestToken42';
OC.linkToRemoteBase = jasmine.createSpy();

TimezoneService = {};
TimezoneService.getDetected = jasmine.createSpy();

$provide.value('DavClient', DavClient);
$provide.value('StringUtility', StringUtility);
$provide.value('XMLUtility', XMLUtility);
$provide.value('CalendarFactory', CalendarFactory);
$provide.value('WebCal', WebCal);
$provide.value('isPublic', true);
$provide.value('constants', {});
$provide.value('TimezoneService', TimezoneService);
}));

beforeEach(inject(function (_$q_, _$rootScope_) {
Expand All @@ -1536,6 +1548,7 @@ describe('CalendarService - public', function() {

OC.linkToRemoteBase.and.returnValue('remote-dav');
DavClient.buildUrl.and.returnValues('fancy-url-1', 'fancy-url-2', 'fancy-url-3', 'fancy-url-4');
TimezoneService.getDetected.and.returnValue('Europe/Berlin');

firstPropFindDeferred = $q.defer();
secondPropFindDeferred = $q.defer();
Expand Down

0 comments on commit 4e6b0bf

Please sign in to comment.