Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UNDO event deletion #13

Closed
georgehrke opened this issue Sep 17, 2016 · 6 comments
Closed

UNDO event deletion #13

georgehrke opened this issue Sep 17, 2016 · 6 comments
Assignees
Labels
1. to develop Accepted and waiting to be taken care of enhancement New feature request skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills

Comments

@georgehrke
Copy link
Member

georgehrke commented Sep 17, 2016


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@georgehrke georgehrke added 1. to develop Accepted and waiting to be taken care of enhancement New feature request skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills labels Sep 17, 2016
@georgehrke georgehrke added this to the 1.5-current milestone Sep 17, 2016
@georgehrke
Copy link
Member Author

georgehrke commented Sep 20, 2016

My current approach is a yellow notification at the top.
This notification will disappear after n seconds.
If the user clicks the notification, the deletion will be undone.

@nextcloud/designers What's a reasonable time after which the notification can disappear?

@eppfel
Copy link
Member

eppfel commented Sep 20, 2016

This touches on the bigger issue of notifications in general. see nextcloud/server#301

@jancborchardt
Copy link
Member

@georgehrke the general agreed upon time is 7 seconds. 5 is just a bit too short to notice, and 10 is too long.

And yeah, just to clarify: We talked about this if we want to use an undo notification in the place where it happens or on top. Right now it seems a notification up top is better since then it’s out of the way and seems quicker. We can directly fade out / animate away the element. @georgehrke the animation part is important for visual feedback, check how we do it in the Mail app with slideUp. :)

@georgehrke georgehrke added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Oct 22, 2016
@georgehrke georgehrke self-assigned this Oct 22, 2016
@georgehrke georgehrke modified the milestones: 1.6.0-next, 1.5.0-current Dec 5, 2016
@georgehrke georgehrke added 1. to develop Accepted and waiting to be taken care of and removed 3. to review Waiting for reviews labels Apr 3, 2017
@georgehrke georgehrke modified the milestones: 1.8.0, 1.6.0-current Apr 3, 2017
@patrice-geo
Copy link

Even with the undo function, there should have a confirm prompt in the first place, as explained in #573

@jancborchardt
Copy link
Member

@patrice-geo no, both confirmation and undo do not make sense. You can read about why confirm prompts are a bad idea at https://alistapart.com/article/neveruseawarning

@tcitworld
Copy link
Member

Is this still worth it with the trashbin?

@ChristophWurst ChristophWurst modified the milestones: v2.3.0, v2.4.0 Jun 24, 2021
@ChristophWurst ChristophWurst modified the milestones: v2.4.0, v2.4.1 Nov 25, 2021
@tcitworld tcitworld removed this from the v2.4.1 milestone Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of enhancement New feature request skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants