Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show "Calendar will be deleted" clearly in the UI #196

Closed
hardfire opened this issue Sep 10, 2018 · 5 comments
Closed

Show "Calendar will be deleted" clearly in the UI #196

hardfire opened this issue Sep 10, 2018 · 5 comments

Comments

@hardfire
Copy link

hardfire commented Sep 10, 2018

Steps to reproduce

  1. Click on three dots
  2. Click on delete
  3. Click on the trash icon

Expected behaviour

The delete interface should clearly mention that the calendar would also be deleted.

Actual behaviour

The app shows a popover only after the countdown starts. I realized there was a message only after clicking on the trash icon and it was too late by the time i realized it.

I don't remember all that i had in my calendar, so now i am not sure if i lost something important or now. I think the UI should be more clear and not just a popup in the case of deletion, especially because i just installed the tasks app to test and I saw there was a "Personal" task list. I didn't realize it came from my calendar which is also named Personal. Only after it was too late :(

@raimund-schluessler
Copy link
Member

@hardfire So do I understand it correctly, that the confusion is about that also the events in the calendar will be deleted and not only the tasks? What would be your suggestion to make this more clear?

To improve that, we could:

  • Change the text in the tooltip from This will delete the Calendar xyz and all of its entries. to 'This will delete the Calendar xyz and all corresponding events and tasks.
  • Show the tooltip permanently and not only on hover. This would maybe give more time to actually read it.

@hardfire What dou you think?

Anyway, in the end this will all be a lot better once we have the undo option for calendars, see nextcloud/calendar#12, nextcloud/calendar#13 and also nextcloud/server#3216.

Also, please consider doing a backup of your database regularly. This is recommended anyway in case of hardware failure or other havoc and would safe you after accidental data deletion.

@skjnldsv as well, because we talked about the confirmation prompt recently.

@skjnldsv
Copy link
Member

@raimund-schluessler Yes, changing the message could be enough for now I guess :)

@hardfire
Copy link
Author

@raimund-schluessler yes! that's correct. In my case, showing the tooltip permanently would have helped.

@raimund-schluessler
Copy link
Member

Fix is in #197 and also implemented in the Vue branch with e53d54a

@hardfire
Copy link
Author

Pretty cool! thank you so much for the quick response and fix! :D love this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants